Skip to content

[TCPStore] use wait counters #135283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[TCPStore] use wait counters #135283

wants to merge 1 commit into from

Conversation

d4l3k
Copy link
Member

@d4l3k d4l3k commented Sep 5, 2024 •
edited by pytorch-bot bot
Loading

This replaces the existing TCPStore counters with the new shared wait counters. There's no users of the tcpstore counters so should be completely safe to remove.

Test plan:

Existing tests + build

There's no OSS backend for wait counters so can't write any tests with them currently.

cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @c-p-i-o

@d4l3k d4l3k requested review from asiab4 and c-p-i-o September 5, 2024 23:55
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135283

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 7031d11 with merge base d6b9bd3 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category labels Sep 5, 2024
c-p-i-o
c-p-i-o approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@c-p-i-o c-p-i-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice!

@d4l3k
Copy link
Member Author

d4l3k commented Sep 6, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 6, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@d4l3k
Copy link
Member Author

d4l3k commented Sep 6, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased d4l3k/tcpstore_counters onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout d4l3k/tcpstore_counters && git pull --rebase)

@d4l3k
Copy link
Member Author

d4l3k commented Sep 6, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@d4l3k d4l3k deleted the d4l3k/tcpstore_counters branch September 6, 2024 20:06
Jokeren pushed a commit to Jokeren/pytorch that referenced this pull request Sep 6, 2024
@d4l3k @Jokeren
[TCPStore] use wait counters (pytorch#135283)
2e7f020 
This replaces the existing TCPStore counters with the new shared wait counters. There's no users of the tcpstore counters so should be completely safe to remove.

Test plan:

Existing tests + build

There's no OSS backend for wait counters so can't write any tests with them currently.

Pull Request resolved: pytorch#135283
Approved by: https://github.com/c-p-i-o

Update

Lint
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@d4l3k @Chao1Han
[TCPStore] use wait counters (pytorch#135283)
7b98a37 
This replaces the existing TCPStore counters with the new shared wait counters. There's no users of the tcpstore counters so should be completely safe to remove.

Test plan:

Existing tests + build

There's no OSS backend for wait counters so can't write any tests with them currently.

Pull Request resolved: pytorch#135283
Approved by: https://github.com/c-p-i-o
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asiab4 asiab4 Awaiting requested review from asiab4

1 more reviewer

@c-p-i-o c-p-i-o c-p-i-o approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@d4l3k @pytorchmergebot @c-p-i-o