Skip to content

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Sep 9, 2024

Relax the restrictions.

Copy link

pytorch-bot bot commented Sep 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135467

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1f4655f with merge base c0436c5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Sep 9, 2024
@cyyever cyyever changed the title Check function declarations of COREML code Check function declarations of core ML code Sep 9, 2024
@cyyever cyyever changed the title Check function declarations of core ML code Check function declarations of Core ML code Sep 9, 2024
@cyyever cyyever added the module: ios Related to iOS support - build, API, Continuous Integration, document label Sep 9, 2024
@cyyever cyyever requested a review from ezyang September 10, 2024 01:19
@ezyang
Copy link
Contributor

ezyang commented Sep 10, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 10, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the COREMLdeclaration branch September 10, 2024 23:29
@malfet
Copy link
Contributor

malfet commented Sep 12, 2024

@pytorchbot revert -m "This breaks ios periodic jobs, see https://github.com/pytorch/pytorch/actions/runs/10797026668/job/29947377532" -c nosignal

@malfet malfet added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Sep 12, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Sep 12, 2024
@pytorchmergebot
Copy link
Collaborator

@cyyever your PR has been successfully reverted.

@cyyever cyyever restored the COREMLdeclaration branch September 14, 2024 02:37
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
pytorchmergebot pushed a commit that referenced this pull request Sep 26, 2024
Reland of #135467 by fixing periodic workflows.
Pull Request resolved: #136070
Approved by: https://github.com/ezyang
@cyyever cyyever deleted the COREMLdeclaration branch October 26, 2024 08:02
@cyyever cyyever restored the COREMLdeclaration branch October 26, 2024 08:02
@cyyever cyyever deleted the COREMLdeclaration branch December 9, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged module: ios Related to iOS support - build, API, Continuous Integration, document open source release notes: jit release notes category Reverted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants