Skip to content

[AOTI] Move stack_allocation logic from CppWrapperCpu #136462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[AOTI] Move stack_allocation logic from CppWrapperCpu #136462

wants to merge 3 commits into from

Conversation

@desertfire
Copy link
Contributor

@desertfire desertfire commented Sep 23, 2024 •
edited
Loading

@desertfire
[AOTI] Move stack_allocation logic from CppWrapperCpu
02c86c1 
Summary: Move stack_allocation logic from CppWrapperCpu to CppWrapperCpuArrayRef

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136462

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b8a41d0 with merge base 663e760 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Sep 23, 2024
Closed
Closed
Closed
@desertfire
Update on "[AOTI] Move stack_allocation logic from CppWrapperCpu"
2b9e325 
Summary: Move stack_allocation logic from CppWrapperCpu to CppWrapperCpuArrayRef

[ghstack-poisoned]
@desertfire desertfire added the topic: not user facing topic category label Sep 23, 2024
@desertfire
Copy link
Contributor Author

@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@desertfire
Update on "[AOTI] Move stack_allocation logic from CppWrapperCpu"
b8a41d0 
Summary: Move stack_allocation logic from CppWrapperCpu to CppWrapperCpuArrayRef

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang

Differential Revision: [D63300359](https://our.internmc.facebook.com/intern/diff/D63300359)

[ghstack-poisoned]
desertfire added a commit that referenced this pull request Sep 24, 2024
@desertfire
[AOTI] Move stack_allocation logic from CppWrapperCpu
adee4a7 
Summary: Move stack_allocation logic from CppWrapperCpu to CppWrapperCpuArrayRef

ghstack-source-id: 29b3c91
Pull Request resolved: #136462
@desertfire
Copy link
Contributor Author

@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@desertfire
Copy link
Contributor Author

@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@desertfire desertfire mentioned this pull request Sep 24, 2024
Closed
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 24, 2024
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Sep 25, 2024
@desertfire @pytorchmergebot
[AOTI] Move stack_allocation logic from PythonWrapperCodegen (#136463)
20a855b 
Summary: Move stack_allocation logic from PythonWrapperCodegen to CppWrapperCpuArrayRef

Differential Revision: [D63319970](https://our.internmc.facebook.com/intern/diff/D63319970)
Pull Request resolved: #136463
Approved by: https://github.com/chenyang78
ghstack dependencies: #136062, #136461, #136462
BoyuanFeng pushed a commit to BoyuanFeng/pytorch that referenced this pull request Sep 25, 2024
@desertfire @BoyuanFeng
[AOTI] Move stack_allocation logic from CppWrapperCpu (pytorch#136462)
40bf8cc 
Summary: Move stack_allocation logic from CppWrapperCpu to CppWrapperCpuArrayRef

Differential Revision: [D63300359](https://our.internmc.facebook.com/intern/diff/D63300359)
Pull Request resolved: pytorch#136462
Approved by: https://github.com/chenyang78
ghstack dependencies: pytorch#136062, pytorch#136461
BoyuanFeng pushed a commit to BoyuanFeng/pytorch that referenced this pull request Sep 25, 2024
@desertfire @BoyuanFeng
[AOTI] Move stack_allocation logic from PythonWrapperCodegen (pytorch…
f7fd6b9 
…#136463)

Summary: Move stack_allocation logic from PythonWrapperCodegen to CppWrapperCpuArrayRef

Differential Revision: [D63319970](https://our.internmc.facebook.com/intern/diff/D63319970)
Pull Request resolved: pytorch#136463
Approved by: https://github.com/chenyang78
ghstack dependencies: pytorch#136062, pytorch#136461, pytorch#136462
@github-actions github-actions bot deleted the gh/desertfire/465/head branch October 27, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenyang78 chenyang78 chenyang78 approved these changes

@hl475 hl475 Awaiting requested review from hl475

@angelayi angelayi Awaiting requested review from angelayi

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@desertfire @facebook-github-bot @pytorchmergebot @chenyang78