Skip to content

[FR] Make OSS fr_trace function available for internal script and improve pg filtering #136473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[FR] Make OSS fr_trace function available for internal script and improve pg filtering #136473

wants to merge 2 commits into from

Conversation

fduwjj
Copy link
Contributor

@fduwjj fduwjj commented Sep 23, 2024 •
edited
Loading

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 23, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136473

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8c54d3f with merge base b6ffa38 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

fduwjj added a commit that referenced this pull request Sep 23, 2024
@fduwjj
[FR] Make OSS fr_trace function available for internal script and imp…
2923d9e 
…rove pg filtering

Differential Revision: [D63287384](https://our.internmc.facebook.com/intern/diff/D63287384/)

ghstack-source-id: 244261431
Pull Request resolved: #136473
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63287384

@fduwjj
Update on "[FR] Make OSS fr_trace function available for internal scr…
8c54d3f 
…ipt and improve pg filtering"

Differential Revision: [D63287384](https://our.internmc.facebook.com/intern/diff/D63287384/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63287384

fduwjj added a commit that referenced this pull request Sep 23, 2024
@fduwjj
[FR] Make OSS fr_trace function available for internal script and imp…
11380fc 
…rove pg filtering

Pull Request resolved: #136473


ghstack-source-id: 244273012

Differential Revision: [D63287384](https://our.internmc.facebook.com/intern/diff/D63287384/)
fduwjj
fduwjj commented Sep 23, 2024
View reviewed changes
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 23, 2024
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

skotapati pushed a commit to kulinseth/pytorch that referenced this pull request Sep 24, 2024
@fduwjj @skotapati
[FR] Make OSS fr_trace function available for internal script and imp…
e85f697 
…rove pg filtering (pytorch#136473)

Differential Revision: [D63287384](https://our.internmc.facebook.com/intern/diff/D63287384/)
Pull Request resolved: pytorch#136473
Approved by: https://github.com/c-p-i-o
BoyuanFeng pushed a commit to BoyuanFeng/pytorch that referenced this pull request Sep 25, 2024
@fduwjj @BoyuanFeng
[FR] Make OSS fr_trace function available for internal script and imp…
7366776 
…rove pg filtering (pytorch#136473)

Differential Revision: [D63287384](https://our.internmc.facebook.com/intern/diff/D63287384/)
Pull Request resolved: pytorch#136473
Approved by: https://github.com/c-p-i-o
@github-actions github-actions bot deleted the gh/fduwjj/138/head branch October 25, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@c-p-i-o c-p-i-o c-p-i-o approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fduwjj @facebook-github-bot @pytorchmergebot @c-p-i-o