[JIT] Optional undefined tensor support #13650
Conversation
wanchaol
changed the title
facebook-github-bot
added
the
oncall: jit
wanchaol
force-pushed
the
undefinedtensor
branch
2 times, most recently
from
edc3f40 to
dc7b35c
Compare
There was a problem hiding this comment.
@wanchaol has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
wanchaol
force-pushed
the
undefinedtensor
branch
2 times, most recently
from
2ade406 to
56a4a7c
Compare
There was a problem hiding this comment.
@wanchaol has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
aten/src/ATen/core/ivalue.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
aten/src/ATen/core/ivalue.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
test/test_jit.py
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
aten/src/ATen/core/jit_type.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
aten/src/ATen/core/jit_type.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
torch/csrc/jit/script/compiler.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
wanchaol
force-pushed
the
undefinedtensor
branch
3 times, most recently
from
d7d603c to
1bc515a
Compare
wanchaol
force-pushed
the
undefinedtensor
branch
from
1bc515a to
ddea54a
Compare
There was a problem hiding this comment.
@wanchaol has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: This PR is a part of task to unblock standard library export. * we treat None differently from Tensor and other types, when passing None as Tensor, it's an undefined tensor rather than the None IValue. * Refine the type system so that we have correct tensor types hierarchy (Dynamic/Tensor/CompleteTensor), Dynamic should be at the top of the inheritance hierarchy. * It also tries to export bilinear as an example of undefined tensor(None) input. Pull Request resolved: pytorch/pytorch#13650 Differential Revision: D12967026 Pulled By: wanchaol fbshipit-source-id: 6aedccc7ce2a12fadd13d9e620c03e1260103a5a
6 participants
This PR is a part of task to unblock standard library export.