Fixed dead lock in execution trace #136892
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengfukevin
requested review from
aaronenyeshi and
sraikund16
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136892
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8379465 with merge base 10f16cc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D63556608 |
shengfukevin
force-pushed
the
export-D63556608
branch
from
f198602 to
f0e0469
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63556608 |
shengfukevin
force-pushed
the
export-D63556608
branch
from
f0e0469 to
d073b06
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63556608 |
|
What use case was impacting this? Profiler only? |
aaronenyeshi
approved these changes
Oct 7, 2024
shengfukevin
force-pushed
the
export-D63556608
branch
from
d073b06 to
b35fc36
Compare
pytorch-bot bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
Summary: This DIFF is to fix dead lock issue in execution issue. ExecutionTraceObserver get a lock in recordOperatorStart and onFunctionExit. However, inside these two functions, the input/ouput values are evaluated, which will triger python GIL in some use cases. In this case, the lock order is ET locker -> GIL. One of the ads application get GIL first, then call all-gather to collect some metrics from all ranks. When ET is on, all-gather is captured by ET observer. In this case, the lock order is: GIL -> ET locker That is the reason why dead lock happens. To fix it, I changed the ET locker scope, so the input/output evaluation is no longer inside the scope of the ET locker. Test Plan: buck2 test mode/opt caffe2/test:test_profiler_cuda Reviewed By: aaronenyeshi Differential Revision: D63556608
|
This pull request was exported from Phabricator. Differential Revision: D63556608 |
Summary: This DIFF is to fix dead lock issue in execution issue. ExecutionTraceObserver get a lock in recordOperatorStart and onFunctionExit. However, inside these two functions, the input/ouput values are evaluated, which will triger python GIL in some use cases. In this case, the lock order is ET locker -> GIL. One of the ads application get GIL first, then call all-gather to collect some metrics from all ranks. When ET is on, all-gather is captured by ET observer. In this case, the lock order is: GIL -> ET locker That is the reason why dead lock happens. To fix it, I changed the ET locker scope, so the input/output evaluation is no longer inside the scope of the ET locker. I created a stress test in this diff https://www.internalfb.com/diff/D64220205 Test Plan: buck2 test mode/opt caffe2/test:test_profiler_cuda Reviewed By: aaronenyeshi Differential Revision: D63556608
shengfukevin
force-pushed
the
export-D63556608
branch
from
b35fc36 to
8379465
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63556608 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
SamGinzburg
pushed a commit
that referenced
this pull request
Oct 28, 2024
Summary: This DIFF is to fix dead lock issue in execution issue. ExecutionTraceObserver get a lock in recordOperatorStart and onFunctionExit. However, inside these two functions, the input/ouput values are evaluated, which will triger python GIL in some use cases. In this case, the lock order is ET locker -> GIL. One of the ads application get GIL first, then call all-gather to collect some metrics from all ranks. When ET is on, all-gather is captured by ET observer. In this case, the lock order is: GIL -> ET locker That is the reason why dead lock happens. To fix it, I changed the ET locker scope, so the input/output evaluation is no longer inside the scope of the ET locker. Test Plan: buck2 test mode/opt caffe2/test:test_profiler_cuda Differential Revision: D63556608 Pull Request resolved: #136892 Approved by: https://github.com/aaronenyeshi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This DIFF is to fix dead lock issue in execution issue. ExecutionTraceObserver get a lock in recordOperatorStart and onFunctionExit. However, inside these two functions, the input/ouput values are evaluated, which will triger python GIL in some use cases. In this case, the lock order is ET locker -> GIL.
One of the ads application get GIL first, then call all-gather to collect some metrics from all ranks. When ET is on, all-gather is captured by ET observer. In this case, the lock order is: GIL -> ET locker
That is the reason why dead lock happens. To fix it, I changed the ET locker scope, so the input/output evaluation is no longer inside the scope of the ET locker.
Test Plan: buck2 test mode/opt caffe2/test:test_profiler_cuda
Differential Revision: D63556608