-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[DTensor] Register replication strategy for a few upsampling interpolate ops #137201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137201
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4abdf2a with merge base 8962610 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replicate strategy should be fine for now.
Ye. I look at the ops and it doesn't seem we can improve sharding strategy for these ones so it would always require redistributing to replicate. |
|
How would the replicated DTensor get converted back to sharded in the state dict load flow? |
Ah. Thanks for raising it. We won't be able to define the layout for the output, since it is determined by the next op. In order to shard it back, users would have to do a |
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
To unblock Llama 3.2 vision's use case to resize positional embeddings for fine-tuning. Context in workplace post.
cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wconstab @d4l3k @c-p-i-o @tianyu-l