Skip to content

[MTIA](3/n) Implement CPU pins functions for MTIA hooks #137283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[MTIA](3/n) Implement CPU pins functions for MTIA hooks #137283

wants to merge 1 commit into from

Conversation

ttrung149
Copy link
Member

Summary: Link CPU pins function in MTIA hooks to the host allocator implementation

Test Plan:
signals
unit test in D63709424

Differential Revision: D63352770

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 3, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137283

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a5954da with merge base 592e3a3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63352770

@nautsimon nautsimon added the topic: not user facing topic category label Oct 3, 2024
@egienvalue egienvalue self-requested a review October 3, 2024 18:38
egienvalue
egienvalue approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@egienvalue egienvalue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 3, 2024
@ttrung149 @facebook-github-bot
[MTIA](3/n) Implement CPU pins functions for MTIA hooks (pytorch#137283)
a5954da 
Summary:

Link CPU pins function in MTIA hooks to the host allocator implementation

Test Plan:
signals
unit test in D63709424

Reviewed By: egienvalue

Differential Revision: D63352770
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63352770

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@egienvalue egienvalue egienvalue approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ttrung149 @facebook-github-bot @pytorchmergebot @egienvalue @nautsimon