[AutoAC] Backward Pass Aware AC - changes to partitioner to acommodate SOLVER as a callable #137314
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137314
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit f7b8d36 with merge base f4b415d ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D63714905 |
Chillee
force-pushed
the
export-D63714905
branch
from
e0f055d to
fc305f8
Compare
…e SOLVER as a callable (pytorch#137314) Summary: making it so that the config can pass `config.activation_memory_budget_solver` as a callable method and then that callable is invoked to determine the set of saved/recomputed nodes. Test Plan: tbd Reviewed By: Chillee, basilwong Differential Revision: D63714905
|
This pull request was exported from Phabricator. Differential Revision: D63714905 |
| saved_node_idx, recomp_node_idx = SOLVER( | ||
| memory, joint_graph, max_memory, node_info, all_recomputable_banned_nodes | ||
| ) | ||
| return (0.0, saved_node_idx, recomp_node_idx) |
There was a problem hiding this comment.
Nice, will rebase changes onto tuple
…e SOLVER as a callable (pytorch#137314) Summary: making it so that the config can pass `config.activation_memory_budget_solver` as a callable method and then that callable is invoked to determine the set of saved/recomputed nodes. Test Plan: tbd Reviewed By: Chillee, basilwong Differential Revision: D63714905
Chillee
force-pushed
the
export-D63714905
branch
from
fc305f8 to
5ef999e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63714905 |
…e SOLVER as a callable (pytorch#137314) Summary: making it so that the config can pass `config.activation_memory_budget_solver` as a callable method and then that callable is invoked to determine the set of saved/recomputed nodes. Test Plan: tbd Reviewed By: Chillee, basilwong Differential Revision: D63714905
Chillee
force-pushed
the
export-D63714905
branch
from
5ef999e to
f7b8d36
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63714905 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge -f 'I need to merge this to fix ShipIt, however, might need to revert this after if it breaks trunk' |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m 'The failure shows up in trunk' -c ignoredsignal functorch/test_ac.py::MemoryBudgetTest::test_attention_vs_linear GH job link HUD commit link |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@Chillee your PR has been successfully reverted. |
…commodate SOLVER as a callable (#137314)" This reverts commit 932b994. Reverted #137314 on behalf of https://github.com/huydhn due to The failure shows up in trunk ([comment](#137314 (comment)))
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
7 participants
Summary: making it so that the config can pass
config.activation_memory_budget_solveras a callable method and then that callable is invoked to determine the set of saved/recomputed nodes.Test Plan: tbd
Reviewed By: Chillee, basilwong
Differential Revision: D63714905