Skip to content

Conversation

yinghai
Copy link
Contributor

@yinghai yinghai commented Nov 8, 2018

Summary: We need to support types beside int64 and float.

Differential Revision: D12967258

@yinghai yinghai requested review from bddppq and houseroad November 8, 2018 21:18
Copy link

@rdzhabarov rdzhabarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! +1 for explicit types instead of auto in those cases.

This comment was marked as off-topic.

This comment was marked as off-topic.

Summary:
Pull Request resolved: pytorch#13745

We need to support types beside `int64` and `float`.

Differential Revision: D12967258

fbshipit-source-id: 8ac68342c2a02328042065922915870b615947aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants