Skip to content

Conversation

guangyey
Copy link
Collaborator

@guangyey guangyey commented Oct 14, 2024

Stack from ghstack (oldest at bottom):

Motivation

Due to the code change of #135567, triton-xpu needs to fetch tensor.data_ptr() via uint64 instead of int64, refer to intel/intel-xpu-backend-for-triton#2192

Additional Context

triton commit comes from release branch: https://github.com/intel/intel-xpu-backend-for-triton/tree/release/3.2.0

@guangyey guangyey requested review from a team, EikanWang and gujinghui as code owners October 14, 2024 10:47
Copy link

pytorch-bot bot commented Oct 14, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137886

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit bc428ce with merge base 9b89fa4 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@guangyey guangyey requested a review from atalman October 14, 2024 10:48
@guangyey guangyey changed the title update triton xpu commit pin Update triton xpu commit pin Oct 14, 2024
@guangyey guangyey requested a review from malfet October 14, 2024 10:48
@guangyey guangyey added ciflow/xpu Run XPU CI tasks release notes: xpu release notes category labels Oct 14, 2024
guangyey added a commit that referenced this pull request Oct 14, 2024
ghstack-source-id: a29083a
Pull Request resolved: #137886
[ghstack-poisoned]
[ghstack-poisoned]
@guangyey
Copy link
Collaborator Author

These failures are related with intel/intel-xpu-backend-for-triton#2488.

@guangyey guangyey changed the title Update triton xpu commit pin [WIP] Update triton xpu commit pin Oct 15, 2024
[ghstack-poisoned]
[ghstack-poisoned]
guangyey added a commit that referenced this pull request Oct 18, 2024
ghstack-source-id: 2e2c599
Pull Request resolved: #137886
guangyey added a commit that referenced this pull request Oct 18, 2024
ghstack-source-id: c0dac4f
Pull Request resolved: #137886
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/guangyey/76/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/137886)

pytorchmergebot pushed a commit that referenced this pull request Nov 27, 2024
ghstack-source-id: bd3ed7a
Pull Request resolved: #137886
@guangyey
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/guangyey/76/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/137886)

guangyey added a commit that referenced this pull request Nov 27, 2024
ghstack-source-id: d158cfd
Pull Request resolved: #137886
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@chuanqi129
Copy link
Collaborator

The only one UT failure appeared in doctests, there is an issue to track it #141705

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@EikanWang
Copy link
Collaborator

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu), xpu / linux-jammy-xpu-2025_0-py3.9 / test (default, 1, 4, linux.idc.xpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Nov 28, 2024
Triton xpu build was stopped by #139206 temporally to wait triton xpu upgrade PR #137886 landed.

Works for #139722 and #114850

Pull Request resolved: #141775
Approved by: https://github.com/atalman
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
# Motivation
Due to the code change of pytorch#135567, triton-xpu needs to fetch `tensor.data_ptr()` via `uint64` instead of `int64`, refer to intel/intel-xpu-backend-for-triton#2192

# Additional Context
triton commit comes from release branch: https://github.com/intel/intel-xpu-backend-for-triton/tree/release/3.2.0
Pull Request resolved: pytorch#137886
Approved by: https://github.com/EikanWang, https://github.com/atalman
ghstack dependencies: pytorch#135567
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
Triton xpu build was stopped by pytorch#139206 temporally to wait triton xpu upgrade PR pytorch#137886 landed.

Works for pytorch#139722 and pytorch#114850

Pull Request resolved: pytorch#141775
Approved by: https://github.com/atalman
@github-actions github-actions bot deleted the gh/guangyey/76/head branch December 30, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged open source release notes: xpu release notes category topic: not user facing topic category

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants