Add Reshape if there is add_axis when exporting C2 concat #13798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yinghai
force-pushed
the
export-D13012867
branch
from
56e939d to
6ed02a9
Compare
yinghai
force-pushed
the
export-D13012867
branch
from
6ed02a9 to
67674d6
Compare
yinghai
force-pushed
the
export-D13012867
branch
from
67674d6 to
a70ce31
Compare
yinghai
force-pushed
the
export-D13012867
branch
from
a70ce31 to
8786645
Compare
houseroad
reviewed
Nov 12, 2018
caffe2/onnx/onnx_exporter.cc
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Addressed comments. |
yinghai
force-pushed
the
export-D13012867
branch
from
8786645 to
ef9d61d
Compare
yinghai
force-pushed
the
export-D13012867
branch
from
ef9d61d to
2a43656
Compare
) Summary: Pull Request resolved: pytorch#13798 The semantics of C2 and ONNX Concat is a bit different. C2 concat accepts "add_axis" arg and will raise the dim if so. It's equivalent of attaching a Reshape after plain concat in ONNX. Reviewed By: rdzhabarov Differential Revision: D13012867 fbshipit-source-id: dae10c85b19f1c765bc952ff4e71fe815e8c2536
yinghai
force-pushed
the
export-D13012867
branch
from
2a43656 to
dfec794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The semantics of C2 and ONNX Concat is a bit different. C2 concat accepts "add_axis" arg and will raise the dim if so. It's equivalent of attaching a Reshape after plain concat in ONNX.
Differential Revision: D13012867