-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add missing data types at torch export serialization #138561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138561
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit d8fd395 with merge base 941da90 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
torch/_export/serde/schema.yaml
Outdated
- 7 | ||
- 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a version downgrade from 8.1 to 7.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I think this downgrade was due to an old version of main branch of my fork. I have reverted the changes on schema.yaml.
Could you please grant a CI approval? Thanks
e69dd93
to
e4c2c09
Compare
Please seek CI approval before scheduling CIFlow labels |
e4c2c09
to
2b67584
Compare
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
@pytorchbot rebase -b main |
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
Successfully rebased |
2b67584
to
c4c6d06
Compare
torch/_export/serde/schema.py
Outdated
BOOL = 12 | ||
BFLOAT16 = 13 | ||
FLOAT8_E4M3FN = 14 | ||
FLOAT8_E5M2 = 15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we follow this enumeration?
Lines 85 to 88 in b740a1b
_(c10::Float8_e5m2, Float8_e5m2) /* 23 */ \ | |
_(c10::Float8_e4m3fn, Float8_e4m3fn) /* 24 */ \ | |
_(c10::Float8_e5m2fnuz, Float8_e5m2fnuz) /* 25 */ \ | |
_(c10::Float8_e4m3fnuz, Float8_e4m3fnuz) /* 26 */ \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Angela, I have made modifications accordingly.
@pytorchbot rebase -b main |
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
4fb65e3
to
0076353
Compare
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot revert -m="Diff reverted internally" -c="ghfirst" This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).) |
@pytorchbot successfully started a revert job. Check the current status here. |
@yintong-lu your PR has been successfully reverted. |
This reverts commit 1ef1b3b. Reverted #138561 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](#138561 (comment)))
This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
0076353
to
c0083b8
Compare
Related to pytorch#131654 Added missing FP8 data types at torch export serialization. Added test cases of FP8 data types. Pull Request resolved: pytorch#138561 Approved by: https://github.com/jerryzh168, https://github.com/jgong5
…#138561)" This reverts commit 1ef1b3b. Reverted pytorch#138561 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](pytorch#138561 (comment)))
d8fd395
to
60a5050
Compare
Related to #131654
Added missing FP8 data types at torch export serialization.
Added test cases of FP8 data types.
cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov @xmfan