Skip to content

Conversation

yintong-lu
Copy link
Contributor

@yintong-lu yintong-lu commented Oct 22, 2024

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 22, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138561

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit d8fd395 with merge base 941da90 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 23, 2024
@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Nov 11, 2024
jerryzh168
jerryzh168 previously approved these changes Nov 12, 2024
Comment on lines 435 to 463
- 7
- 3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a version downgrade from 8.1 to 7.3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I think this downgrade was due to an old version of main branch of my fork. I have reverted the changes on schema.yaml.
Could you please grant a CI approval? Thanks

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 19, 2024

Please seek CI approval before scheduling CIFlow labels

@yintong-lu
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #138561, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@yintong-lu
Copy link
Contributor Author

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased add_export_serial_type onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout add_export_serial_type && git pull --rebase)

jgong5
jgong5 previously approved these changes Nov 20, 2024
BOOL = 12
BFLOAT16 = 13
FLOAT8_E4M3FN = 14
FLOAT8_E5M2 = 15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we follow this enumeration?

_(c10::Float8_e5m2, Float8_e5m2) /* 23 */ \
_(c10::Float8_e4m3fn, Float8_e4m3fn) /* 24 */ \
_(c10::Float8_e5m2fnuz, Float8_e5m2fnuz) /* 25 */ \
_(c10::Float8_e4m3fnuz, Float8_e4m3fnuz) /* 26 */ \

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Angela, I have made modifications accordingly.

@yintong-lu
Copy link
Contributor Author

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased add_export_serial_type onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout add_export_serial_type && git pull --rebase)

@EikanWang
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 28, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot
Copy link
Contributor

@pytorchbot revert -m="Diff reverted internally" -c="ghfirst"

This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).)

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@yintong-lu your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Dec 3, 2024
@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Dec 3, 2024
@pytorch-bot pytorch-bot bot dismissed stale reviews from jerryzh168 and jgong5 December 3, 2024 01:32

This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.

@albanD albanD removed their request for review December 3, 2024 03:15
@guangyey
Copy link
Collaborator

guangyey commented Dec 3, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased add_export_serial_type onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout add_export_serial_type && git pull --rebase)

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
Related to pytorch#131654

Added missing FP8 data types at torch export serialization.
Added test cases of FP8 data types.

Pull Request resolved: pytorch#138561
Approved by: https://github.com/jerryzh168, https://github.com/jgong5
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@yintong-lu yintong-lu closed this Jan 8, 2025
@yintong-lu yintong-lu force-pushed the add_export_serial_type branch from d8fd395 to 60a5050 Compare January 8, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request Merged module: compiled autograd compiled_autograd module: cpu CPU specific problem (e.g., perf, algorithm) module: dynamo module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: export release notes: quantization release notes category Reverted topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.