Improve input validation for NJT pointwise ops #138602
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138602
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b99667a with merge base 046f02d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
good point, it does reject it. I thought we'd hit the |
Before this PR, we were using the number of passed tensor args to determine whether to dispatch to unary / binary pointwise impls. This had the unintended consequence of allowing e.g. `NJT * nested_int`, wrongly interpreting the SymInt as a tensor and outputting garbage. We should check the func schema itself to be more accurate. [ghstack-poisoned]
|
Updated PR to do a dumber check for any nested ints before dispatching on pointwise ops. |
soulitzer
approved these changes
Oct 22, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
SamGinzburg
pushed a commit
that referenced
this pull request
Oct 28, 2024
Before this PR, NJT would dispatch e.g. `NJT * nested_int` to `mul.Tensor`, wrongly interpreting the SymInt as a tensor and outputting garbage. This PR verifies that there are no nested ints in the list of args before dispatching for pointwise ops. I originally tried checking that `the number of passed tensor args == the number of func schema tensor args`, but this wrongly disallows `nt * 2`, which (non-intuitively to me at least at first) dispatches via the `mul.Tensor` overload. Pull Request resolved: #138602 Approved by: https://github.com/soulitzer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Before this PR, NJT would dispatch e.g.
NJT * nested_inttomul.Tensor, wrongly interpreting the SymInt as a tensor and outputting garbage. This PR verifies that there are no nested ints in the list of args before dispatching for pointwise ops.I originally tried checking that
the number of passed tensor args == the number of func schema tensor args, but this wrongly disallowsnt * 2, which (non-intuitively to me at least at first) dispatches via themul.Tensoroverload.