Skip to content

Conversation

soumith
Copy link
Member

@soumith soumith commented Nov 13, 2018

Adds symbolic diff and tests.

Copy link
Contributor

@apaszke apaszke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh I’m a bit terrified with the thought that we’ll have to maintain this testing code

@soumith
Copy link
Member Author

soumith commented Nov 13, 2018

@apaszke this will go away after planned work of auto-binding most of the backward formulas will happen. Until then, I can maintain it.

@ailzhang , @zdevito and I are formulating a plan there.

@soumith soumith force-pushed the new_symbolic_diff branch 2 times, most recently from dcdac73 to 1b2147d Compare November 14, 2018 03:49
Copy link
Contributor

@zdevito zdevito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- a couple places should use graph->insert rather than graph->create.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soumith has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants