Fix some nits in symbolic_shapes.py #139018
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139018
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d08412e with merge base a874ec8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
bobrenjc93
commented
Oct 27, 2024
| return {inspect.getfile(m) for m in mods} | ||
|
|
||
|
|
||
| # We don't bother with the metaclass as all of the dispatching logic happens |
There was a problem hiding this comment.
This comment was introduced in #83330 but never removed when SymDispatchMode was deleted.
bobrenjc93
requested review from
aorenste,
avikchaudhuri,
ezyang and
laithsakka
bobrenjc93
changed the title
ezyang
approved these changes
Oct 28, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
While I was reading through this file for understanding, I fixed some nits.
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv