Skip to content

Conversation

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Oct 28, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139024

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit b040560 with merge base 9039fbb (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

etaf added 5 commits October 27, 2024 19:53
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@etaf etaf requested a review from fengyuan14 October 29, 2024 10:42
@etaf etaf marked this pull request as ready for review October 29, 2024 10:43
@etaf etaf requested a review from EikanWang October 29, 2024 10:43
@etaf etaf added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 30, 2024
@etaf etaf requested review from desertfire and jansel October 30, 2024 03:39
[ghstack-poisoned]
@etaf etaf requested a review from fengyuan14 October 31, 2024 02:28
@etaf etaf changed the title [Intel GPU] Current libtorch_xpu.so double linked libtorch_xpu_ops.a, [Intel GPU] Avoid target_link_libraries twice for torch_xpu_ops which will potentially cause multiple definition symbol linker error. Oct 31, 2024
@etaf etaf requested a review from EikanWang October 31, 2024 02:31
Copy link
Collaborator

@EikanWang EikanWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[ghstack-poisoned]
[ghstack-poisoned]
@EikanWang
Copy link
Collaborator

@xianxl , pls. ensure the ci signal is green

etaf added 3 commits November 3, 2024 16:28
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@etaf
Copy link
Collaborator Author

etaf commented Nov 5, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

atalman pushed a commit to atalman/pytorch that referenced this pull request Nov 11, 2024
… will potentially cause multiple definition symbol linker error. (pytorch#139024)

[Intel GPU] Avoid target_link_libraries twice for torch_xpu_ops which will potentially cause multiple definition symbol linker error.
Pull Request resolved: pytorch#139024
Approved by: https://github.com/EikanWang, https://github.com/fengyuan14, https://github.com/jansel
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
… will potentially cause multiple definition symbol linker error. (pytorch#139024)

[Intel GPU] Avoid target_link_libraries twice for torch_xpu_ops which will potentially cause multiple definition symbol linker error.
Pull Request resolved: pytorch#139024
Approved by: https://github.com/EikanWang, https://github.com/fengyuan14, https://github.com/jansel
@github-actions github-actions bot deleted the gh/etaf/52/head branch December 6, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged open source topic: not user facing topic category

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants