Skip to content

Conversation

guangyey
Copy link
Collaborator

@guangyey guangyey commented Oct 28, 2024

Stack from ghstack (oldest at bottom):

Motivation

This PR intends to update torch-xpu-ops commit pin. It mainly includes the following two highlighted changes:

  1. split the DLL library into 4 smaller libraries to avoid the 2G limitation on Windows;
  2. some new operators added, for example, cdist, pdist, maxunpool2d, maxunpood3d, upsample_trilinear3d, Bessel operators`, etc...

Additional Context

We have to supply XPU device check logic in cdist and pdist ops.
This PR depends on #139050 to fix Windows build issue.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 28, 2024
Copy link

pytorch-bot bot commented Oct 28, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139041

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d23228e with merge base 38645e8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

guangyey added a commit that referenced this pull request Oct 28, 2024
ghstack-source-id: 732aeb2
Pull Request resolved: #139041
@guangyey guangyey marked this pull request as draft October 28, 2024 06:05
@guangyey guangyey changed the title Update torch-xpu-ops commit pin [WIP] Update torch-xpu-ops commit pin Oct 28, 2024
@guangyey guangyey added the ciflow/xpu Run XPU CI tasks label Oct 28, 2024
@guangyey
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #139041, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

pytorchmergebot pushed a commit that referenced this pull request Oct 28, 2024
ghstack-source-id: 732aeb2
Pull Request resolved: #139041
[ghstack-poisoned]
@guangyey
Copy link
Collaborator Author

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/guangyey/82/orig onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/139041)

pytorchmergebot pushed a commit that referenced this pull request Oct 29, 2024
ghstack-source-id: 2144fbf
Pull Request resolved: #139041
@guangyey guangyey marked this pull request as ready for review October 29, 2024 10:10
@guangyey guangyey changed the title [WIP] Update torch-xpu-ops commit pin Update torch-xpu-ops commit pin Oct 29, 2024
@guangyey guangyey requested review from atalman, ezyang and malfet October 29, 2024 10:11
[ghstack-poisoned]
[ghstack-poisoned]
@guangyey
Copy link
Collaborator Author

@malfet and @atalman May I know if you could help review this PR?

@EikanWang
Copy link
Collaborator

#139050 landed.

@ZzEeKkAa
Copy link

Please include this fix intel/torch-xpu-ops#1032 to the PR

@ezyang
Copy link
Contributor

ezyang commented Oct 31, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 31, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@guangyey
Copy link
Collaborator Author

Please include this fix intel/torch-xpu-ops#1032 to the PR

This is not must to have. Let's include this PR in the next commit update.

@guangyey
Copy link
Collaborator Author

@ezyang Thanks very much~

rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
# Motivation
This PR intends to update torch-xpu-ops commit pin. It mainly includes the following two highlighted changes:
1. split the DLL library into 4 smaller libraries to avoid the 2G limitation on Windows;
2. some new operators added, for example, `cdist`, `pdist`, `maxunpool2d`, `maxunpood3d`, `upsample_trilinear3d, `Bessel operators`, etc...

# Additional Context
We have to supply XPU device check logic in `cdist` and `pdist` ops.
This PR depends on pytorch#139050 to fix Windows build issue.
Pull Request resolved: pytorch#139041
Approved by: https://github.com/EikanWang, https://github.com/ezyang
@github-actions github-actions bot deleted the gh/guangyey/82/head branch December 1, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants