Skip to content

[inductor] Enable AMD cooperative reduction tests #139230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[inductor] Enable AMD cooperative reduction tests #139230

wants to merge 2 commits into from

Conversation

jansel
Copy link
Contributor

@jansel jansel commented Oct 29, 2024 •
edited
Loading

@jansel
Update
99e339a 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 29, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139230

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 04fe521 with merge base 44257c0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jansel added a commit that referenced this pull request Oct 29, 2024
@jansel
[inductor] Enable AMD cooperative reduction tests
b688666 
ghstack-source-id: 452f1e7
Pull Request resolved: #139230
@jansel jansel mentioned this pull request Oct 29, 2024
Closed
@jansel jansel added module: rocm AMD GPU support for Pytorch ciflow/rocm Trigger "default" config CI on ROCm labels Oct 29, 2024
@jansel
Copy link
Contributor Author

jansel commented Oct 30, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@jansel
Update
04fe521 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/jansel/427/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/139230)

pytorchmergebot pushed a commit that referenced this pull request Oct 30, 2024
@jansel
[inductor] Enable AMD cooperative reduction tests
cf97a3a 
ghstack-source-id: 5d90529
Pull Request resolved: #139230
@jansel jansel requested review from eellison and jataylo October 30, 2024 22:52
@jansel
Copy link
Contributor Author

jansel commented Oct 31, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 31, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
@jansel @rahulsingh-intel
[inductor] Enable AMD cooperative reduction tests (pytorch#139230)
bc665db 
Fixes pytorch#139099

Pull Request resolved: pytorch#139230
Approved by: https://github.com/eellison
@github-actions github-actions bot deleted the gh/jansel/427/head branch December 1, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eellison eellison eellison approved these changes

@jataylo jataylo Awaiting requested review from jataylo

Assignees

No one assigned

Labels

ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor module: rocm AMD GPU support for Pytorch topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jansel @pytorchmergebot @eellison