Skip to content

Conversation

saumishr
Copy link
Contributor

@saumishr saumishr commented Oct 30, 2024

Summary: Unit Test to validate the stateful and non-stateful loads. This test is a follow up to the fix in #138575 which addresses an issue in stateful dict's in-place updates in distributed checkpoint loading. Also, added additional code comments regarding the stateful and non-stateful loads.

Test Plan:

buck2 test //caffe2/test/distributed/checkpoint/e2e:test_e2e_save_and_load

https://www.internalfb.com/intern/testinfra/testrun/8162774562859797

Differential Revision: D65188659

cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @LucasLLC @MeetVadakkanchery @mhorowitz @pradeepfn

@pytorch-bot pytorch-bot bot added module: distributed_checkpoint oncall: distributed Add this issue/PR to distributed oncall triage queue labels Oct 30, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139251

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 381d3d1 with merge base 77e25d5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65188659

@saumishr saumishr changed the title [DCP] Unit Test to validate the stateful and non-stateful loads in DCP OSS [DCP] Unit Test to validate the stateful and non-stateful loads Oct 30, 2024
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 30, 2024
…P OSS (pytorch#139251)

Summary:

Unit Test to validate the stateful and non-stateful loads. This test is a follow up to the fix in [pytorch#138575](pytorch#138575) which addresses an issue in stateful dict's in-place updates in distributed checkpoint loading. Also, added additional code comments regarding the stateful and non-stateful loads.

Test Plan:
```
buck2 test //caffe2/test/distributed/checkpoint/e2e:test_e2e_save_and_load
```

https://www.internalfb.com/intern/testinfra/testrun/8162774562859797

Differential Revision: D65188659
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65188659

Copy link
Contributor

@LucasLLC LucasLLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
…rch#139251)

Summary: Unit Test to validate the stateful and non-stateful loads. This test is a follow up to the fix in [pytorch#138575](pytorch#138575) which addresses an issue in stateful dict's in-place updates in distributed checkpoint loading. Also, added additional code comments regarding the stateful and non-stateful loads.

Test Plan:
```
buck2 test //caffe2/test/distributed/checkpoint/e2e:test_e2e_save_and_load
```

https://www.internalfb.com/intern/testinfra/testrun/8162774562859797

Differential Revision: D65188659

Pull Request resolved: pytorch#139251
Approved by: https://github.com/LucasLLC, https://github.com/fegin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (checkpoint)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants