-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[DCP] Unit Test to validate the stateful and non-stateful loads #139251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139251
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 381d3d1 with merge base 77e25d5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D65188659 |
…P OSS (pytorch#139251) Summary: Unit Test to validate the stateful and non-stateful loads. This test is a follow up to the fix in [pytorch#138575](pytorch#138575) which addresses an issue in stateful dict's in-place updates in distributed checkpoint loading. Also, added additional code comments regarding the stateful and non-stateful loads. Test Plan: ``` buck2 test //caffe2/test/distributed/checkpoint/e2e:test_e2e_save_and_load ``` https://www.internalfb.com/intern/testinfra/testrun/8162774562859797 Differential Revision: D65188659
ab2f755
to
a1c1fbd
Compare
This pull request was exported from Phabricator. Differential Revision: D65188659 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…rch#139251) Summary: Unit Test to validate the stateful and non-stateful loads. This test is a follow up to the fix in [pytorch#138575](pytorch#138575) which addresses an issue in stateful dict's in-place updates in distributed checkpoint loading. Also, added additional code comments regarding the stateful and non-stateful loads. Test Plan: ``` buck2 test //caffe2/test/distributed/checkpoint/e2e:test_e2e_save_and_load ``` https://www.internalfb.com/intern/testinfra/testrun/8162774562859797 Differential Revision: D65188659 Pull Request resolved: pytorch#139251 Approved by: https://github.com/LucasLLC, https://github.com/fegin
Summary: Unit Test to validate the stateful and non-stateful loads. This test is a follow up to the fix in #138575 which addresses an issue in stateful dict's in-place updates in distributed checkpoint loading. Also, added additional code comments regarding the stateful and non-stateful loads.
Test Plan:
https://www.internalfb.com/intern/testinfra/testrun/8162774562859797
Differential Revision: D65188659
cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @LucasLLC @MeetVadakkanchery @mhorowitz @pradeepfn