[easy] Add start event metadata to collected metadata for PT2 Compile Events #139289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Events We should be logging metadata from event starts to PT2 Compile Events too. Differential Revision: [D65070086](https://our.internmc.facebook.com/intern/diff/D65070086/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139289
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7b6d3b3 with merge base 69d401d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D65070086 |
jamesjwu
added a commit
that referenced
this pull request
Oct 30, 2024
… Events We should be logging metadata from event starts to PT2 Compile Events too. Differential Revision: [D65070086](https://our.internmc.facebook.com/intern/diff/D65070086/) ghstack-source-id: 250444771 Pull Request resolved: #139289
oulgen
approved these changes
Oct 30, 2024
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Oct 31, 2024
Summary: X-link: pytorch/pytorch#139289 We should be logging metadata from event starts to PT2 Compile Events too. ghstack-source-id: 250444771 Reviewed By: oulgen Differential Revision: D65070086 fbshipit-source-id: 63b934bff4254871e15a615e5aa47112b032b143
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
… Events (pytorch#139289) We should be logging metadata from event starts to PT2 Compile Events too. Differential Revision: [D65070086](https://our.internmc.facebook.com/intern/diff/D65070086/) Pull Request resolved: pytorch#139289 Approved by: https://github.com/oulgen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
We should be logging metadata from event starts to PT2 Compile Events too.
Differential Revision: D65070086
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames