Update setup.py to support Nvidia TX2 #13939
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add platform.machine() == 'aarch64' for supporting Nvidia TX2
soumith
reviewed
Nov 14, 2018
setup.py
Outdated
| IS_DARWIN = (platform.system() == 'Darwin') | ||
| IS_LINUX = (platform.system() == 'Linux') | ||
| IS_PPC = (platform.machine() == 'ppc64le') | ||
| IS_PPC_AAR = (platform.machine() == 'ppc64le' or platform.machine() == 'aarch64') |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
soumith
approved these changes
Nov 14, 2018
add IS_ARM = (platform.machine() == 'aarch64') # ppc64le and aarch64 do not support MKLDNN if IS_PPC or IS_ARM:
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add platform.machine() == 'aarch64' for supporting Nvidia TX2