Avoid overflow in float32-to-int32 test #139489
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Triton has added some integer overflow detection when kernels are compiled with `debug=True`, and this test results in integer overflow (2.0 is 0x40000000, times 2 is 0x80000000 which overflows a signed int32). Assertion `int32 overflow detected for operation mul` failed Fixes #139479 Test Plan: ``` python inductor/test_torchinductor.py -k test_float32_to_int32_cuda ``` [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139489
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 78d2d05 with merge base 3f9f604 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary: Triton has added some integer overflow detection when kernels are compiled with `debug=True`, and this test results in integer overflow (2.0 is 0x40000000, times 2 is 0x80000000 which overflows a signed int32). Assertion `int32 overflow detected for operation mul` failed Fixes #139479 Test Plan: ``` python inductor/test_torchinductor.py -k test_float32_to_int32_cuda ``` [ghstack-poisoned]
bertmaher
changed the title
bertmaher
added a commit
that referenced
this pull request
Nov 1, 2024
Summary: Triton has added some integer overflow detection when kernels are compiled with `debug=True`, and this test results in integer overflow (2.0 is 0x40000000, times 2 is 0x80000000 which overflows a signed int32). Assertion `int32 overflow detected for operation mul` failed Fixes #139479 Test Plan: ``` python inductor/test_torchinductor.py -k test_float32_to_int32_cuda ``` ghstack-source-id: dc30067 Pull Request resolved: #139489
eellison
approved these changes
Nov 1, 2024
jansel
approved these changes
Nov 1, 2024
chenyang78
approved these changes
Nov 1, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
Summary: Triton has added some integer overflow detection when kernels are compiled with `debug=True`, and this test results in integer overflow (2.0 is 0x40000000, times 2 is 0x80000000 which overflows a signed int32). Assertion `int32 overflow detected for operation mul` failed Fixes pytorch#139479 Test Plan: ``` python inductor/test_torchinductor.py -k test_float32_to_int32_cuda ``` Pull Request resolved: pytorch#139489 Approved by: https://github.com/eellison, https://github.com/jansel, https://github.com/chenyang78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Triton has added some integer overflow detection when kernels are compiled with
debug=True, and this test results in integer overflow (2.0 is 0x40000000,times 2 is 0x80000000 which overflows a signed int32).
Assertion
int32 overflow detected for operation mulfailedFixes #139479
Test Plan:
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov