Skip to content

[dynamo][eval_frame] Set the callback to None earlier for guard eval #139655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[dynamo][eval_frame] Set the callback to None earlier for guard eval #139655

wants to merge 2 commits into from

Conversation

anijain2305
Copy link
Contributor

@anijain2305 anijain2305 commented Nov 4, 2024 •
edited
Loading

@anijain2305 anijain2305 mentioned this pull request Nov 4, 2024
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139655

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit fd1a7dc with merge base 740054f (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

anijain2305
anijain2305 commented Nov 4, 2024
View reviewed changes
torch/csrc/dynamo/eval_frame.c
// We don't run the current custom_eval_frame behavior for guards.
// So we temporarily set the callback to Py_None to drive the correct behavior
// in the shim.
eval_frame_callback_set(Py_None);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ensure that for torch._dynamo.run mode or extra_state_cache_limit_hit(extra) also has callback disabled (condition at L624)

@anijain2305 anijain2305 added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category ciflow/inductor labels Nov 4, 2024
@anijain2305
Update on "[dynamo][eval_frame] Set the callback to None earlier for …
fd1a7dc 
…guard eval"


xref - https://fb.workplace.com/groups/1075192433118967/permalink/1536570810314458/

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
williamwen42
williamwen42 approved these changes Nov 4, 2024
View reviewed changes
torch/csrc/dynamo/eval_frame.c
// used cached version
DEBUG_TRACE("cache hit %s", get_frame_name(frame));
// Re-enable custom behavior
eval_frame_callback_set(callback);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we don't need to also do this in the return NULL line (L637) because we'd be crashing there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@anijain2305
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 5, 5, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@anijain2305
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 5, 5, linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@anijain2305
[dynamo][eval_frame] Set the callback to None earlier for guard eval (p…
ff71be4 
…ytorch#139655)

xref - https://fb.workplace.com/groups/1075192433118967/permalink/1536570810314458/

Pull Request resolved: pytorch#139655
Approved by: https://github.com/jansel, https://github.com/williamwen42
@github-actions github-actions bot deleted the gh/anijain2305/575/head branch December 6, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@williamwen42 williamwen42 williamwen42 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anijain2305 @pytorchmergebot @jansel @williamwen42