Skip to content

[7/N] Don't skip ASAN on some tests #139675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[7/N] Don't skip ASAN on some tests #139675

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Nov 4, 2024 •
edited
Loading

Follows #139565

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 4, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139675

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d111441 with merge base a678eaf (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever marked this pull request as draft November 4, 2024 23:50
@cyyever cyyever changed the title Enable skipped ASAN tests [7/N] Don't skip ASAN on some tests Nov 5, 2024
@cyyever cyyever marked this pull request as ready for review November 5, 2024 03:28
@cyyever cyyever requested a review from ezyang November 5, 2024 03:28
@cyyever
Copy link
Collaborator Author

cyyever commented Nov 5, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 5, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever
Copy link
Collaborator Author

cyyever commented Nov 5, 2024

@pytorchbot merge -f "ASAN passed"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the skip_asan20 branch November 9, 2024 03:33
Ryo-not-rio pushed a commit to Ryo-not-rio/pytorch that referenced this pull request Dec 2, 2024
@cyyever @Ryo-not-rio
[7/N] Don't skip ASAN on some tests (pytorch#139675)
4bfe6e6 
Follows pytorch#139565
Pull Request resolved: pytorch#139675
Approved by: https://github.com/ezyang
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@cyyever
[7/N] Don't skip ASAN on some tests (pytorch#139675)
2972f92 
Follows pytorch#139565
Pull Request resolved: pytorch#139675
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cyyever @pytorchmergebot @ezyang @pytorchbot