Add proper from_blob overloads #13982
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumith
reviewed
Nov 14, 2018
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
goldsborough
force-pushed
the
from-blob
branch
from
8976477 to
388c2b1
Compare
|
@soumith fixed, also added tests for |
soumith
approved these changes
Nov 15, 2018
goldsborough
force-pushed
the
from-blob
branch
from
388c2b1 to
c930132
Compare
There was a problem hiding this comment.
@goldsborough is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 26, 2018
Summary: There was an overload for `torch::from_blob` missing that allowed passing strides. ezyang soumith Pull Request resolved: pytorch/pytorch#13982 Differential Revision: D13108089 Pulled By: goldsborough fbshipit-source-id: b87594ec0bf55b35d106b4438bc18b2ce9fc8f71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an overload for
torch::from_blobmissing that allowed passing strides.@ezyang @soumith