[export] Disable AttrProxy when every submodule has a unique path. #139918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139918
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5e3317f with merge base c35a011 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D65555919 |
zhxchen17
requested review from
angelayi,
avikchaudhuri,
tugsbayasgalan and
ydwu4
tugsbayasgalan
approved these changes
Nov 6, 2024
…ytorch#139918) Summary: In most cases, we don't need to turn on AttrProxy tracing for two reasons: 1. It's only needed when you have one submodule owning multiple FQNs. 2. AND it will cause model using module identity to be traced incorrectly (because we substitute module objects at tracing time). Overall after offline discussion with some export folk, we think it's better to turn off AttrProxy if we can make sure every submodule has unique FQN, which tends to be the common case. Test Plan: buck test mode/opt caffe2/test:test_export -- -r module_dict_key Reviewed By: tugsbayasgalan Differential Revision: D65555919
zhxchen17
force-pushed
the
export-D65555919
branch
from
c7e7f70 to
5e3317f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65555919 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…ytorch#139918) Summary: In most cases, we don't need to turn on AttrProxy tracing for two reasons: 1. It's only needed when you have one submodule owning multiple FQNs. 2. AND it will cause model using module identity to be traced incorrectly (because we substitute module objects at tracing time). Overall after offline discussion with some export folk, we think it's better to turn off AttrProxy if we can make sure every submodule has unique FQN, which tends to be the common case. Test Plan: buck test mode/opt caffe2/test:test_export -- -r module_dict_key Differential Revision: D65555919 Pull Request resolved: pytorch#139918 Approved by: https://github.com/tugsbayasgalan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In most cases, we don't need to turn on AttrProxy tracing for two reasons:
Overall after offline discussion with some export folk, we think it's better to turn off AttrProxy if we can make sure every submodule has unique FQN, which tends to be the common case.
Test Plan: buck test mode/opt caffe2/test:test_export -- -r module_dict_key
Differential Revision: D65555919
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv