OpenReg: Support event #140111
Closed
OpenReg: Support event #140111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140111
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 77a8591 with merge base 81d077c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
colesbury
added
the
triaged
ezyang
reviewed
Nov 10, 2024
| const noexcept override { | ||
| py::gil_scoped_acquire acquire; | ||
| get_method("destroyEvent")(event, device_index); | ||
| get_method("destroyEvent")((int64_t)event, device_index); |
There was a problem hiding this comment.
nit use static_cast<int64_t>(event) and co
ezyang
approved these changes
Nov 10, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Ryo-not-rio
pushed a commit
to Ryo-not-rio/pytorch
that referenced
this pull request
Dec 2, 2024
Support events. Since cpu backend doesn't support asynchronous execution, all event operations will be executed immediately on the executor side. Pull Request resolved: pytorch#140111 Approved by: https://github.com/ezyang
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Support events. Since cpu backend doesn't support asynchronous execution, all event operations will be executed immediately on the executor side. Pull Request resolved: pytorch#140111 Approved by: https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support events. Since cpu backend doesn't support asynchronous execution, all event operations will be executed immediately on the executor side.
cc @ezyang @albanD