Skip to content

[SymmetricMemory] fix a bug in symm_mem::memset32_ where the ops fails when offset=0 #140129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[SymmetricMemory] fix a bug in symm_mem::memset32_ where the ops fails when offset=0 #140129

wants to merge 4 commits into from

Conversation

yifuwang
Copy link
Collaborator

@yifuwang yifuwang commented Nov 8, 2024 •
edited
Loading

This was referenced Nov 8, 2024
Closed
Closed
@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category labels Nov 8, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 8, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140129

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 73d2504 with merge base 62eea62 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

yifuwang pushed a commit that referenced this pull request Nov 8, 2024
[SymmetricMemory] fix a bug in symm_mem::memset32_ where the ops fail…
3596171 
…s when offset=0

ghstack-source-id: f84abe4
Pull Request resolved: #140129
@yifuwang yifuwang requested a review from lw November 8, 2024 10:19
@yifuwang yifuwang added the topic: not user facing topic category label Nov 8, 2024
@yifuwang yifuwang requested a review from weifengpy November 8, 2024 10:20
lw
lw approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@lw lw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yifuwang
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

Update
6d4bc09 
[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Nov 13, 2024
[SymmetricMemory] fix a bug in symm_mem::memset32_ where the ops fail…
3ed7f58 
…s when offset=0

ghstack-source-id: 2865552
Pull Request resolved: #140129
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/yifuwang/171/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/140129)

Update on "[SymmetricMemory] fix a bug in symm_mem::memset32_ where t…
ad33fde 
…he ops fails when offset=0"

cc H-Huang awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o

[ghstack-poisoned]
This was referenced Nov 5, 2024
Closed
Closed
Update on "[SymmetricMemory] fix a bug in symm_mem::memset32_ where t…
73d2504 
…he ops fails when offset=0"

cc H-Huang awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o

[ghstack-poisoned]
@yifuwang
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 14, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Ryo-not-rio pushed a commit to Ryo-not-rio/pytorch that referenced this pull request Dec 2, 2024
@Ryo-not-rio
[SymmetricMemory] fix a bug in symm_mem::memset32_ where the ops fail…
5ee4cb3 
…s when offset=0 (pytorch#140129)

Pull Request resolved: pytorch#140129
Approved by: https://github.com/lw
ghstack dependencies: pytorch#140127, pytorch#140128
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
[SymmetricMemory] fix a bug in symm_mem::memset32_ where the ops fail…
eea3aec 
…s when offset=0 (pytorch#140129)

Pull Request resolved: pytorch#140129
Approved by: https://github.com/lw
ghstack dependencies: pytorch#140127, pytorch#140128
fmo-mt pushed a commit to fmo-mt/pytorch that referenced this pull request Dec 11, 2024
@fmo-mt
[SymmetricMemory] fix a bug in symm_mem::memset32_ where the ops fail…
4e100a2 
…s when offset=0 (pytorch#140129)

Pull Request resolved: pytorch#140129
Approved by: https://github.com/lw
ghstack dependencies: pytorch#140127, pytorch#140128
Esquains pushed a commit to Esquains/study1 that referenced this pull request Dec 15, 2024
[SymmetricMemory] fix a bug in symm_mem::memset32_ where the ops fail…
98f0063 
…s when offset=0

ghstack-source-id: 3c74c6c
Pull Request resolved: pytorch/pytorch#140129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lw lw lw approved these changes

@weifengpy weifengpy Awaiting requested review from weifengpy

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yifuwang @pytorchmergebot @lw