Skip to content

Conversation

@Mousius
Copy link
Contributor

@Mousius Mousius commented Nov 21, 2024

This changes the hardcoded assumptions of a 256-bit vector length to querying from cpu_vec_isa and changes relevant tests to share the logic.

Also refactored the config.cpp.simdlen != 1 into the assertion so we stop duplicating it throughout the test cases.

Fixes issues on 128-bit machines.

cc @malfet @snadampal @milpuz01 @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141245

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 83f8933 with merge base 5fd881a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Mousius
Copy link
Contributor Author

Mousius commented Nov 21, 2024

@pytorchbot label "module: arm"

@pytorch-bot pytorch-bot bot added the module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 label Nov 21, 2024
@bdhirsh bdhirsh requested a review from desertfire November 26, 2024 00:32
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 26, 2024
@Mousius Mousius force-pushed the get-simd-lengths-in-cpu-repro branch from fdd60db to ee439a6 Compare November 28, 2024 15:16
@Mousius
Copy link
Contributor Author

Mousius commented Dec 3, 2024

@pytorchbot merge -r

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 3, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased get-simd-lengths-in-cpu-repro onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout get-simd-lengths-in-cpu-repro && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@Mousius
Copy link
Contributor Author

Mousius commented Dec 5, 2024

@desertfire could you nudge CI for me please?

@Mousius
Copy link
Contributor Author

Mousius commented Dec 9, 2024

Or maybe @malfet? 😸

@malfet
Copy link
Contributor

malfet commented Jan 21, 2025

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

This changes the hardcoded assumptions of a `256-bit` vector length to querying from `cpu_vec_isa` and changes relevant tests to share the logic.

Also refactored the `config.cpp.simdlen != 1` into the assertion so we stop duplicating it throughout the test cases.
@pytorchmergebot
Copy link
Collaborator

Successfully rebased get-simd-lengths-in-cpu-repro onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout get-simd-lengths-in-cpu-repro && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 21, 2025 22:15 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 21, 2025 22:15 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 21, 2025 22:15 Inactive
@malfet
Copy link
Contributor

malfet commented Jan 22, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 module: inductor open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants