Skip to content

Test cpp_wrapper_hipify string comparison #141353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Test cpp_wrapper_hipify string comparison #141353

wants to merge 2 commits into from

Conversation

iupaikov-amd
Copy link
Collaborator

@iupaikov-amd iupaikov-amd commented Nov 22, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 22, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141353

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4ecaffb with merge base d0fd42e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@iupaikov-amd
Copy link
Collaborator Author

@pytorchbot label "topic: not user facing"

@iupaikov-amd
Copy link
Collaborator Author

@pytorchbot label "rocm"

@pytorch-bot pytorch-bot bot added the rocm This tag is for PRs from ROCm team label Nov 22, 2024
@jithunnair-amd jithunnair-amd added the ciflow/rocm Trigger "default" config CI on ROCm label Nov 25, 2024
@jithunnair-amd
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased iupaikov_test_cpp_wrapper_fix_upstream onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout iupaikov_test_cpp_wrapper_fix_upstream && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the iupaikov_test_cpp_wrapper_fix_upstream branch from f930d6d to 4ecaffb Compare November 25, 2024 17:11
@iupaikov-amd
Copy link
Collaborator Author

@jithunnair-amd @jataylo can you please approve the workflows?

@jataylo jataylo added the ciflow/inductor-rocm Trigger "inductor" config CI on ROCm label Nov 26, 2024
@jataylo
Copy link
Collaborator

jataylo commented Dec 3, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 3, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@iupaikov-amd
Test cpp_wrapper_hipify string comparison (pytorch#141353)
80aa2ca 
Updating the test to match this code that takes device warpsize into account: https://github.com/pytorch/pytorch/blob/cf1d95a965e419cfc3473996aecf50ee9e360a2e/torch/_inductor/codegen/cuda/device_op_overrides.py#L120

Pull Request resolved: pytorch#141353
Approved by: https://github.com/desertfire
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@iupaikov-amd @AmdSampsa
Test cpp_wrapper_hipify string comparison (pytorch#141353)
63aba84 
Updating the test to match this code that takes device warpsize into account: https://github.com/pytorch/pytorch/blob/cf1d95a965e419cfc3473996aecf50ee9e360a2e/torch/_inductor/codegen/cuda/device_op_overrides.py#L120

Pull Request resolved: pytorch#141353
Approved by: https://github.com/desertfire
@iupaikov-amd iupaikov-amd deleted the iupaikov_test_cpp_wrapper_fix_upstream branch December 19, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@desertfire desertfire desertfire approved these changes

@zoranzhao zoranzhao Awaiting requested review from zoranzhao

Assignees

No one assigned

Labels

ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source rocm This tag is for PRs from ROCm team topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@iupaikov-amd @jithunnair-amd @pytorchmergebot @jataylo @desertfire @pytorchbot