Skip to content

[Matmul][CUDA][FP8] Skip rowwise scaling tests on non-sm90 #141596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[Matmul][CUDA][FP8] Skip rowwise scaling tests on non-sm90 #141596

wants to merge 6 commits into from

Conversation

eqy
Copy link
Collaborator

@eqy eqy commented Nov 26, 2024 •
edited by pytorch-bot bot
Loading

Since the current kernel is using sm90-specific features, just pre-emptively skip the test for any non-sm90 compute capabilities

cc @yanbing-j @vkuzo @albanD @kadeng @penguinwu

@eqy eqy added open source topic: not user facing topic category matrix multiplication module: floatx (formerly float8) For torch.float8_e5m2 and torch.float8_e4m3 and other sub 8-bit float types labels Nov 26, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 26, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141596

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 373e2bb with merge base 5d3bc63 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@colesbury colesbury requested a review from drisspg November 26, 2024 21:42
@colesbury colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 26, 2024
@drisspg
Copy link
Contributor

drisspg commented Nov 26, 2024

probably need to and w/ cuda enabled

@eqy eqy added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 10, 2024
@eqy
Copy link
Collaborator Author

eqy commented Dec 10, 2024

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased sm90onlyrowwise onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout sm90onlyrowwise && git pull --rebase)

@eqy
Copy link
Collaborator Author

eqy commented Dec 10, 2024

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorch-bot bot pushed a commit that referenced this pull request Dec 11, 2024
@eqy @mori360
[Matmul][CUDA][FP8] Skip rowwise scaling tests on non-sm90 (#141596)
5a208c1 
Since the current kernel is using sm90-specific features, just pre-emptively skip the test for any non-sm90 compute capabilities

Pull Request resolved: #141596
Approved by: https://github.com/drisspg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drisspg drisspg drisspg approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request matrix multiplication Merged module: floatx (formerly float8) For torch.float8_e5m2 and torch.float8_e4m3 and other sub 8-bit float types open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eqy @drisspg @pytorchmergebot @colesbury