Remove functorch config: _max_aliased_inputs_with_dynamic_shapes_enabled.
#141680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141680
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2c8a9fd with merge base 9dd3b85 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
ysiraichi
added a commit
that referenced
this pull request
Nov 27, 2024
…bled`. This PR removes the functorch config that set an upper limit on the number of aliased inputs with dynamic shapes. After moving them to be run at runtime in C++, the compilation time and runtime (in true alias cases) improved, rendering the error no longer relevant. ghstack-source-id: 70f13f3 Pull Request resolved: #141680
bdhirsh
approved these changes
Dec 3, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
…bled`. (pytorch#141680) This PR removes the functorch config that set an upper limit on the number of aliased inputs with dynamic shapes. After moving them to be run at runtime in C++, the compilation time and runtime (in true alias cases) improved, rendering the error no longer relevant. Pull Request resolved: pytorch#141680 Approved by: https://github.com/bdhirsh ghstack dependencies: pytorch#139554, pytorch#139555, pytorch#140013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
_max_aliased_inputs_with_dynamic_shapes_enabled. #141680tensor._baseas a tracked fake forShapeEnvguards. #139554This PR removes the functorch config that set an upper limit on the number of aliased
inputs with dynamic shapes. After moving them to be run at runtime in C++, the compilation
time and runtime (in true alias cases) improved, rendering the error no longer relevant.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames