[dynamo] Validate mutation_type and source in VariableTracker.__init__
#141717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141717
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 24f6bb6 with merge base 9012e7a ( UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
StrongerXi
added a commit
that referenced
this pull request
Nov 27, 2024
…init__` As title, this also uncovered a few invalid use cases; the cases that cause error are fixed in separate patches prior to this patch, and the rest are fixed in this patch. This patch also moves a few `.source` mutation to variable construction, to increase the coverage of the validation. Fixes #133027. ghstack-source-id: 17faa9a Pull Request resolved: #141717
StrongerXi
added a commit
that referenced
this pull request
Dec 2, 2024
…init__` As title, this also uncovered a few invalid use cases; the cases that cause error are fixed in separate patches prior to this patch, and the rest are fixed in this patch. This patch also - moves a few `.source` mutation to variable construction, to increase the coverage of the validation. - adds `source=None` to a `ConstDictVariable.clone` call to fix an exposed failure from `test_lse_masked_output`. Fixes #133027. ghstack-source-id: 968ea50 Pull Request resolved: #141717
jansel
approved these changes
Dec 3, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…init__` (pytorch#141717) As title, this also uncovered a few invalid use cases; the cases that cause error are fixed in separate patches prior to this patch, and the rest are fixed in this patch. This patch also moves a few `.source` mutation to variable construction, to increase the coverage of the validation. Fixes pytorch#133027. Pull Request resolved: pytorch#141717 Approved by: https://github.com/jansel ghstack dependencies: pytorch#141713, pytorch#141714, pytorch#141715, pytorch#141902, pytorch#141716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
mutation_typeandsourceinVariableTracker.__init__#141717RANGE_ITERATOR_MATCHto properly guard on range iterators #141902dict.copythat escapes the graph #141715collections.deque#141714As title, this also uncovered a few invalid use cases; the cases that
cause error are fixed in separate patches prior to this patch, and the
rest are fixed in this patch.
This patch also moves a few
.sourcemutation to variable construction,to increase the coverage of the validation.
Fixes #133027.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames