Skip to content

Revert #141066 and #141494 #141721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Revert #141066 and #141494 #141721

wants to merge 3 commits into from

Conversation

izaitsevfb
Copy link
Contributor

@izaitsevfb izaitsevfb commented Nov 27, 2024 •
edited by pytorch-bot bot
Loading

@izaitsevfb
Revert "fix non termination in unflatten + state (#141494)"
0bd77f3 
This reverts commit 5d7c370.
@izaitsevfb
Revert "misc. fixes to unflatten (#141066)"
25e6105 
This reverts commit 8b4ae29.
@izaitsevfb
Merge branch 'refs/heads/revert_141066_and_141494' into revert_141066…
6561905 
…_and_141494_1

# Conflicts:
#	test/export/test_export.py
#	torch/export/unflatten.py
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 27, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141721

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 6561905 with merge base dbbebee (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor module: dynamo oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: export labels Nov 27, 2024
@izaitsevfb
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 28, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@izaitsevfb
Revert pytorch#141066 and pytorch#141494 (pytorch#141721)
fc234b8 
manual revert due to merge conflicts

note: pytorch#141494 was reverted out of order blocking automatic revert of pytorch#141066

Pull Request resolved: pytorch#141721
Approved by: https://github.com/avikchaudhuri
@github-actions github-actions bot deleted the revert_141066_and_141494_1 branch December 30, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avikchaudhuri avikchaudhuri avikchaudhuri approved these changes

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

@ydwu4 ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

@angelayi angelayi Awaiting requested review from angelayi angelayi is a code owner

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: export

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@izaitsevfb @pytorchmergebot @avikchaudhuri