Skip to content

[AOTI] Clean up temporary files generated by AOTI package loader. #141773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[AOTI] Clean up temporary files generated by AOTI package loader. #141773

wants to merge 4 commits into from

Conversation

etaf
Copy link
Collaborator

@etaf etaf commented Nov 28, 2024 •
edited
Loading

@etaf
Update
4669f2b 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 28, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141773

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit fa1ef70 with merge base ae9cda0 (image):

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

etaf added a commit that referenced this pull request Nov 28, 2024
@etaf
[AOTI] Clean up temporary files generated by AOTI package loader.
0b9cb38 
Fix #141772

ghstack-source-id: f952bda
Pull Request resolved: #141773
@etaf etaf added the topic: not user facing topic category label Nov 28, 2024
@etaf etaf self-assigned this Nov 28, 2024
@etaf etaf requested a review from EikanWang November 28, 2024 14:24
@etaf etaf requested a review from desertfire November 29, 2024 05:25
desertfire
desertfire requested changes Dec 2, 2024
View reviewed changes
torch/csrc/inductor/aoti_package/model_package_loader.cpp
#endif

#include <filesystem>
namespace fs = std::filesystem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't use std::filesystem due to #133437. I know it's annoying, but until you resolve that linking issue, we have to still with the current way.

@desertfire
Copy link
Contributor

@etaf , any follow-up on this one? I will switch all the AOTI unit test to use the new package API, but this PR needs to land first.

@etaf
Copy link
Collaborator Author

etaf commented Dec 6, 2024

@etaf , any follow-up on this one? I will switch all the AOTI unit test to use the new package API, but this PR needs to land first.

@desertfire thanks, I'm working on it, and will update today.

@etaf
Update
cf82e04 
[ghstack-poisoned]
etaf added a commit that referenced this pull request Dec 6, 2024
@etaf
[AOTI] Clean up temporary files generated by AOTI package loader.
6a7c0e6 
Fix #141772

ghstack-source-id: 79a8600
Pull Request resolved: #141773
@etaf etaf requested a review from desertfire December 6, 2024 03:27
@etaf
Update
421f120 
[ghstack-poisoned]
etaf added a commit that referenced this pull request Dec 6, 2024
@etaf
[AOTI] Clean up temporary files generated by AOTI package loader.
b8f001a 
Fix #141772

ghstack-source-id: c210a4a
Pull Request resolved: #141773
@etaf etaf added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 6, 2024
@etaf
Update
fa1ef70 
[ghstack-poisoned]
etaf added a commit that referenced this pull request Dec 6, 2024
@etaf
[AOTI] Clean up temporary files generated by AOTI package loader.
375909f 
Fix #141772

ghstack-source-id: 6cf3777
Pull Request resolved: #141773
@etaf
Copy link
Collaborator Author

etaf commented Dec 6, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@etaf @AmdSampsa
[AOTI] Clean up temporary files generated by AOTI package loader. (py…
3019724 
…torch#141773)

Fix pytorch#141772
Pull Request resolved: pytorch#141773
Approved by: https://github.com/desertfire, https://github.com/EikanWang
@github-actions github-actions bot deleted the gh/etaf/71/head branch January 6, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@desertfire desertfire desertfire approved these changes

@EikanWang EikanWang EikanWang approved these changes

Assignees

@etaf etaf

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

PyTorch Intel
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@etaf @desertfire @pytorchmergebot @EikanWang @pytorchbot