[dynamo] Remove workaround for `functools.wraps` in functorch #142014

StrongerXi · 2024-12-03T23:18:31Z

Stack from ghstack (oldest at bottom):

This is no longer needed after #142000.

Fixes #123365.

D66838774

[ghstack-poisoned]

pytorch-bot · 2024-12-03T23:18:34Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142014

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit abf8368 with merge base c376b29 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This is no longer needed after #142000. Fixes #123365. ghstack-source-id: 776d8e0 Pull Request resolved: #142014

zou3519 · 2024-12-04T15:44:57Z

torch/_functorch/eager_transforms.py

-    if not torch._dynamo.is_compiling():
-        wrapper_fn = wraps(func)(wrapper_fn)
-
+    wrapper_fn = wraps(func)(wrapper_fn)


Can you put the wraps as a decorator on the wrapper_fn? i.e.

@wraps(func) def wrapper_fn(...): ....

ditto below.

That's how the original code looked like before we did this hack

Ah right, much cleaner, updated.

[ghstack-poisoned]

This is no longer needed after #142000. Fixes #123365. ghstack-source-id: 9851f61 Pull Request resolved: #142014

StrongerXi · 2024-12-04T16:11:13Z

@pytorchbot merge

pytorchmergebot · 2024-12-04T16:13:44Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-12-04T18:57:56Z

Merge failed

Reason: HTTP Error 504: Gateway Timeout

Details for Dev Infra team

Raised by workflow job

StrongerXi · 2024-12-04T19:00:45Z

@pytorchbot merge

pytorchmergebot · 2024-12-04T19:04:43Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…h#142014) This is no longer needed after pytorch#142000. Fixes pytorch#123365. Pull Request resolved: pytorch#142014 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#142000

atalman · 2024-12-05T15:16:56Z

@pytorchmergebot revert -c ghfirst -m "Sorry #142000 is failing internally, need to revert this"

pytorchmergebot · 2024-12-05T15:18:50Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2024-12-05T15:18:59Z

@StrongerXi your PR has been successfully reverted.

…#142014)" This reverts commit ed77901. Reverted #142014 on behalf of https://github.com/atalman due to Sorry #142000 is failing internally, need to revert this ([comment](#142014 (comment)))

facebook-github-bot · 2024-12-06T06:37:23Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2024-12-06T06:39:04Z

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator! Please try reimporting/rexporting the PR!

Details for Dev Infra team

Raised by workflow job

StrongerXi · 2024-12-06T15:35:47Z

@pytorchbot merge -f "unrelated failures"

pytorchmergebot · 2024-12-06T15:37:54Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-12-06T15:38:03Z

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator! Please try reimporting/rexporting the PR!

Details for Dev Infra team

Raised by workflow job

izaitsevfb · 2024-12-06T17:24:28Z

@pytorchbot merge -f "unrelated failures"

pytorchmergebot · 2024-12-06T17:26:04Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-12-06T17:26:27Z

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator! Please try reimporting/rexporting the PR!

Details for Dev Infra team

Raised by workflow job

izaitsevfb · 2024-12-06T17:29:52Z

@pytorchbot merge -f "unrelated failures"

let's try one more time

pytorchmergebot · 2024-12-06T17:31:29Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-12-06T17:31:50Z

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator! Please try reimporting/rexporting the PR!

Details for Dev Infra team

Raised by workflow job

izaitsevfb · 2024-12-06T17:33:08Z

@pytorchbot merge -f "unrelated failures"

third time's a charm
(removed "Differential revision" from the second PR in the stack)

pytorchmergebot · 2024-12-06T17:34:35Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…h#142014) This is no longer needed after pytorch#142000. Fixes pytorch#123365. Pull Request resolved: pytorch#142014 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#142000

…pytorch#142014)" This reverts commit ed77901. Reverted pytorch#142014 on behalf of https://github.com/atalman due to Sorry pytorch#142000 is failing internally, need to revert this ([comment](pytorch#142014 (comment)))

This is no longer needed after #142000. Fixes #123365. D66838774 Pull Request resolved: #142014 Approved by: https://github.com/zou3519 ghstack dependencies: #142000

Update

f064b0d

[ghstack-poisoned]

StrongerXi mentioned this pull request Dec 3, 2024

[dynamo] Simplify handling of functools.wraps #142000

Closed

StrongerXi added a commit that referenced this pull request Dec 3, 2024

[dynamo] Remove workaround for functools.wraps in functorch

5b37e24

This is no longer needed after #142000. Fixes #123365. ghstack-source-id: 776d8e0 Pull Request resolved: #142014

StrongerXi added the topic: not user facing topic category label Dec 3, 2024

StrongerXi requested a review from zou3519 December 4, 2024 15:39

zou3519 reviewed Dec 4, 2024

View reviewed changes

zou3519 approved these changes Dec 4, 2024

View reviewed changes

Update

572aa21

[ghstack-poisoned]

StrongerXi added a commit that referenced this pull request Dec 4, 2024

[dynamo] Remove workaround for functools.wraps in functorch

8569ca1

This is no longer needed after #142000. Fixes #123365. ghstack-source-id: 9851f61 Pull Request resolved: #142014

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 4, 2024

pytorchmergebot added the merging label Dec 4, 2024

pytorchmergebot removed the merging label Dec 4, 2024

pytorchmergebot added the merging label Dec 4, 2024

pytorchmergebot added the Merged label Dec 4, 2024

pytorchmergebot closed this in ed77901 Dec 4, 2024

pytorchmergebot removed the merging label Dec 4, 2024

pytorch deleted a comment from pytorch-bot bot Dec 5, 2024

pytorchmergebot added the Reverted label Dec 5, 2024

pytorchmergebot removed the merging label Dec 6, 2024

pytorchmergebot added the merging label Dec 6, 2024

pytorchmergebot removed the merging label Dec 6, 2024

pytorchmergebot added the merging label Dec 6, 2024

pytorchmergebot removed the merging label Dec 6, 2024

pytorchmergebot added the merging label Dec 6, 2024

pytorchmergebot removed the merging label Dec 6, 2024

pytorchmergebot added the merging label Dec 6, 2024

pytorchmergebot removed the merging label Dec 6, 2024

pytorchmergebot added the merging label Dec 6, 2024

pytorchmergebot closed this in f2f95ba Dec 6, 2024

pytorchmergebot removed the merging label Dec 6, 2024

github-actions bot deleted the gh/StrongerXi/52/head branch January 6, 2025 02:08

[dynamo] Remove workaround for functools.wraps in functorch #142014

[dynamo] Remove workaround for functools.wraps in functorch #142014

Uh oh!

Conversation

StrongerXi commented Dec 3, 2024 • edited by izaitsevfb Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142014

✅ No Failures

Uh oh!

zou3519 Dec 4, 2024

Choose a reason for hiding this comment

Uh oh!

StrongerXi Dec 4, 2024

Choose a reason for hiding this comment

Uh oh!

StrongerXi commented Dec 4, 2024

Uh oh!

pytorchmergebot commented Dec 4, 2024

Merge started

Uh oh!

pytorchmergebot commented Dec 4, 2024

Merge failed

Uh oh!

StrongerXi commented Dec 4, 2024

Uh oh!

pytorchmergebot commented Dec 4, 2024

Merge started

Uh oh!

atalman commented Dec 5, 2024

Uh oh!

pytorchmergebot commented Dec 5, 2024

Uh oh!

pytorchmergebot commented Dec 5, 2024

Uh oh!

facebook-github-bot commented Dec 6, 2024

Uh oh!

pytorchmergebot commented Dec 6, 2024

Merge failed

Uh oh!

StrongerXi commented Dec 6, 2024

Uh oh!

pytorchmergebot commented Dec 6, 2024

Merge started

Uh oh!

pytorchmergebot commented Dec 6, 2024

Merge failed

Uh oh!

izaitsevfb commented Dec 6, 2024

Uh oh!

pytorchmergebot commented Dec 6, 2024

Merge started

Uh oh!

pytorchmergebot commented Dec 6, 2024

Merge failed

Uh oh!

izaitsevfb commented Dec 6, 2024

Uh oh!

pytorchmergebot commented Dec 6, 2024

Merge started

Uh oh!

pytorchmergebot commented Dec 6, 2024

Merge failed

Uh oh!

izaitsevfb commented Dec 6, 2024

Uh oh!

pytorchmergebot commented Dec 6, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[dynamo] Remove workaround for `functools.wraps` in functorch #142014

[dynamo] Remove workaround for `functools.wraps` in functorch #142014

StrongerXi commented Dec 3, 2024 •

edited by izaitsevfb

Loading

pytorch-bot bot commented Dec 3, 2024 •

edited

Loading