Skip to content

Conversation

laithsakka
Copy link
Contributor

@laithsakka laithsakka commented Dec 4, 2024

Stack from ghstack (oldest at bottom):

address #141215 and max recursion issue in
this also optimize perf by avoiding a lot of sympy expressions construction.

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

Copy link

pytorch-bot bot commented Dec 4, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142057

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2347785 with merge base 31f2d4e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Dec 4, 2024
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
@laithsakka laithsakka changed the title avoid recursion in FloorDiv constructor Avoid recursion in FloorDiv constructor Dec 4, 2024
@laithsakka laithsakka added topic: not user facing topic category and removed module: cpu CPU specific problem (e.g., perf, algorithm) labels Dec 4, 2024
@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Dec 4, 2024
address #141215 and max recursion issue in 
this also optimize perf by avoiding a lot of sympy expressions construction.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
address #141215 and max recursion issue in 
this also optimize perf by avoiding a lot of sympy expressions construction.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
laithsakka added a commit that referenced this pull request Dec 4, 2024
ghstack-source-id: 8805bce
Pull Request resolved: #142057
@laithsakka
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 5, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

address #141215 and max recursion issue in 
this also optimize perf by avoiding a lot of sympy expressions construction.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
laithsakka added a commit that referenced this pull request Dec 5, 2024
ghstack-source-id: 06fb40c
Pull Request resolved: #142057
@ezyang
Copy link
Contributor

ezyang commented Dec 5, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorch-bot bot pushed a commit that referenced this pull request Dec 9, 2024
address #141215 and max recursion issue in
this also optimize perf by avoiding a lot of sympy expressions construction.

Pull Request resolved: #142057
Approved by: https://github.com/ezyang
@github-actions github-actions bot deleted the gh/laithsakka/101/head branch January 5, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants