[dynamo] Undo some jvp old workarounds in functorch #142081
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142081
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit cf09388 with merge base 78543e6 ( UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Dec 4, 2024
zou3519
approved these changes
Dec 5, 2024
|
Rebase. |
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
This basically undoes some workarounds introduced in pytorch#119926, the root causes of which have been fixed by pytorch#142078 and other changes in Dynamo. Now that Dynamo traces the spec comparison code, the test also needs update: - removing the `_jvp_treespec_compare` calls in fx graph Pull Request resolved: pytorch#142081 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#142078, pytorch#142080
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
This basically undoes most of the workarounds introduced in pytorch#123118, the root causes of which have been fixed by pytorch#142078. Pull Request resolved: pytorch#142082 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#142078, pytorch#142080, pytorch#142081
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
!=under user-defined__eq__#142078This basically undoes some workarounds introduced in #119926, the
root causes of which have been fixed by #142078 and other changes in
Dynamo.
Now that Dynamo traces the spec comparison code, the test also needs update:
_jvp_treespec_comparecalls in fx graphcc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames