Skip to content

[ROCM] Fix unit test: matmul_small_brute_force_tunableop #142089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[ROCM] Fix unit test: matmul_small_brute_force_tunableop #142089

wants to merge 3 commits into from

Conversation

naromero77amd
Copy link
Collaborator

@naromero77amd naromero77amd commented Dec 4, 2024 •
edited
Loading

Fixes #141636
Fixes #141635
Fixes #141458

Changes include:

  • TunableOp filename that wasn't set properly
  • Activate numerical check (see additional test comment)
  • Entire test in try-finally clause to avoid OS environment variable leakage (see additional test comment)

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142089

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 94a4b1c with merge base aa95618 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: rocm AMD GPU support for Pytorch topic: not user facing topic category ciflow/rocm Trigger "default" config CI on ROCm labels Dec 4, 2024
jeffdaily
jeffdaily approved these changes Dec 4, 2024
View reviewed changes
@naromero77amd
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

naromero77amd and others added 3 commits December 5, 2024 16:31
@naromero77amd @pytorchmergebot
Additional test comments.
6e8b4cd
@naromero77amd @pytorchmergebot
Put test in try-finally block to avoid accidental OS environment leak…
f3cb466 
…ge. Set tunableop filename and activate numerical check.
@naromero77amd @jeffdaily @pytorchmergebot
Update test/test_linalg.py
94a4b1c 
Co-authored-by: Jeff Daily <jeff.daily@amd.com>
@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix_ut_matmul_small_brute_force_tunableop onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix_ut_matmul_small_brute_force_tunableop && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the fix_ut_matmul_small_brute_force_tunableop branch from bf45f90 to 94a4b1c Compare December 5, 2024 16:31
@naromero77amd
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 5, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@naromero77amd @jeffdaily @AmdSampsa
[ROCM] Fix unit test: matmul_small_brute_force_tunableop (pytorch#142089
4e523dc 
)

Fixes pytorch#141636
Fixes pytorch#141635
Fixes pytorch#141458

Changes include:

- TunableOp filename that wasn't set properly
- Activate numerical check (see additional test comment)
- Entire test in try-finally clause to avoid OS environment variable leakage (see additional test comment)

Pull Request resolved: pytorch#142089
Approved by: https://github.com/jeffdaily

Co-authored-by: Jeff Daily <jeff.daily@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffdaily jeffdaily jeffdaily approved these changes

@lezcano lezcano Awaiting requested review from lezcano lezcano is a code owner

@nikitaved nikitaved Awaiting requested review from nikitaved nikitaved is a code owner

@IvanYashchuk IvanYashchuk Awaiting requested review from IvanYashchuk IvanYashchuk is a code owner

Assignees

No one assigned

Labels

ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

4 participants

@naromero77amd @pytorchmergebot @jeffdaily @pytorchbot