[inductor] Parenthesize expression in _helper_sqrt

[stephen-huan]

Fixes #142328. The implied cast-then-sqrt order matches the behavior of the halide backend.

pytorch/torch/_inductor/codegen/halide.py

Lines 115 to 116 in 2cc01cc

	def _helper_sqrt(self, expr):
	return f"hl.sqrt({self.cast_float(self._print(expr))})"

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142352

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit f782afd with merge base 2cc01cc ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

• inductor-rocm / rocm6.2-py3.10-inductor / test (inductor, 1, 2, linux.rocm.gpu.2) (gh) (similar failure)
  ##[error]Credentials could not be loaded, please check your action inputs: Could not load credentials from any providers
• inductor-rocm / rocm6.2-py3.10-inductor / test (inductor, 2, 2, linux.rocm.gpu.2) (gh) (similar failure)
  ##[error]Credentials could not be loaded, please check your action inputs: Could not load credentials from any providers

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: stephen-huan / name: Stephen Huan (f782afd)

[stephen-huan]

@pytorchbot label "topic: not user facing"

[ezyang]

Do you mind popping your minimal reproducer into the test suite too? Thanks!

[ezyang]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[pytorchmergebot]

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor-rocm / rocm6.2-py3.10-inductor / test (inductor, 2, 2, linux.rocm.gpu.2)

Details for Dev Infra team

Raised by workflow job

[stephen-huan]

Added a simple test copied from the issue. I would like to use run_and_get_code / get_code / get_triton_code etc. but I couldn't get it to reproduce the error (maybe I'm doing something silly?). Since it's a syntax error, simply running the code will trigger the error. The added test fails before the commit in the PR and works afterwards.

Merge failure seems unrelated?

[ezyang]

That's fine, running without crashing is good enough for me

[ezyang]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[pytorchmergebot]

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

[ezyang]

@pytorchbot merge -f "unrelated failures only"

[pytorchmergebot]

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here