Remove default constructor lines that do nothing, and fix warnings with clang trunk #14300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smessmer could you please review this |
smessmer
approved these changes
Nov 27, 2018
aten/src/ATen/core/TensorImpl.h
Outdated
There was a problem hiding this comment.
This should be deleted instead. I actually have a diff out fixing this already, see #14429
|
@smessmer thanks, in that case it seems only the changes to those exception classes are needed, since your diff takes care of the issue for |
umanwizard
force-pushed
the
fix_clang_warnings
branch
from
8209fda to
ab62521
Compare
There was a problem hiding this comment.
@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lines removed in this diff were no-op, but confusing: the default constructors in
store_handler.hare implicitly deleted, sincestd::runtime_errorhas no default constructor.Clang added a warning for this behavior in September 2018 (note that the warning is not just for cxx2a, despite the slightly confusing commit message), so building pytorch with a recent build of clang trunk causes spew of this warning, which is fixed by the present PR.