Changing rpath from CMAKE_INSTALL_PREFIX to ORIGIN #14304
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for looking at this! #14321 could be related. |
pjh5
force-pushed
the
no_mac_binary_rpath
branch
from
155e0d1 to
144b06e
Compare
soumith
reviewed
Nov 26, 2018
torch/CMakeLists.txt
Outdated
There was a problem hiding this comment.
dont you also need this for libcaffe2 above?
soumith
reviewed
Nov 26, 2018
torch/CMakeLists.txt
Outdated
There was a problem hiding this comment.
isn't it "$ORIGIN" in quotes? or does it not matter?
There was a problem hiding this comment.
I don't really remember, but I /think/ I remember something with quotes leading to evaluating it on some machines or something. I can add the quotes back and see what happens
soumith
approved these changes
Nov 26, 2018
soumith
approved these changes
Nov 26, 2018
pjh5
force-pushed
the
no_mac_binary_rpath
branch
from
144b06e to
781ec66
Compare
There was a problem hiding this comment.
@pjh5 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
pjh5
changed the title
|
Seems to fix rpaths in the binary builds from some manual checking. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 27, 2018
Summary: See if anything breaks Pull Request resolved: pytorch/pytorch#14304 Differential Revision: D13201418 Pulled By: pjh5 fbshipit-source-id: ac2101b61a23bda37329d4d923c3d9d120e718bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See if anything breaks