-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[BE] Get rid of malfet/checkout@silent-checkout
#143516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Instead use `actions/checkout@v4` with `show-progress: false` Partially adresses #143079
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143516
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5ff3616 with merge base 8d4926e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@pytorchbot merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, there is one PR for this a while back #138739, but we missed it
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
I'm very curious about how you discovered this PR. Did you remember seeing it earlier or did you search for it somehow? |
Yeah, I'm surprised to see it was not merged, as I remember approving that PR |
I saw it earlier and remember it when this PR shows up |
Instead use
actions/checkout@v4
withshow-progress: false
. It's more verbose than the quiet option, but our logs are long anyway...Partially addresses #143079