Skip to content

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Dec 18, 2024

Instead use actions/checkout@v4 with show-progress: false. It's more verbose than the quiet option, but our logs are long anyway...

Partially addresses #143079

Instead use `actions/checkout@v4` with `show-progress: false`

Partially adresses #143079
@malfet malfet requested a review from a team as a code owner December 18, 2024 19:27
Copy link

pytorch-bot bot commented Dec 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143516

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5ff3616 with merge base 8d4926e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 18, 2024
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@malfet
Copy link
Contributor Author

malfet commented Dec 18, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 18, 2024
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, there is one PR for this a while back #138739, but we missed it

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ZainRizvi
Copy link
Contributor

Oops, there is one PR for this a while back #138739, but we missed it

I'm very curious about how you discovered this PR. Did you remember seeing it earlier or did you search for it somehow?

@malfet
Copy link
Contributor Author

malfet commented Dec 18, 2024

Oops, there is one PR for this a while back #138739, but we missed it

Yeah, I'm surprised to see it was not merged, as I remember approving that PR

@huydhn
Copy link
Contributor

huydhn commented Dec 18, 2024

I'm very curious about how you discovered this PR. Did you remember seeing it earlier or did you search for it somehow?

I saw it earlier and remember it when this PR shows up

@bhack
Copy link
Contributor

bhack commented Dec 18, 2024

#138739 (comment)

@github-actions github-actions bot deleted the malfet/replace-silent-checkout-with-show-progress branch January 18, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants