unflatten isinstance #143664
Closed
unflatten isinstance #143664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D67526542](https://our.internmc.facebook.com/intern/diff/D67526542/) [ghstack-poisoned]
avikchaudhuri
requested review from
angelayi,
tugsbayasgalan,
ydwu4 and
zhxchen17
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143664
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d88d39d with merge base 2c48af5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D67526542 |
Differential Revision: [D67526542](https://our.internmc.facebook.com/intern/diff/D67526542/) [ghstack-poisoned]
avikchaudhuri
added a commit
that referenced
this pull request
Dec 20, 2024
Pull Request resolved: #143664 Differential Revision: [D67526542](https://our.internmc.facebook.com/intern/diff/D67526542/) ghstack-source-id: 259149796
pytorch-bot
bot
added
the
oncall: distributed
|
This pull request was exported from Phabricator. Differential Revision: D67526542 |
tugsbayasgalan
approved these changes
Dec 20, 2024
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 21, 2024
Retracing while preserving module call signatures used to be a problem because graph modules don't have submodules at given paths. This led to a number of failing retracebility tests. By not trying to wrap modules with export tracepoints we can pass most of these tests; the only exception is where you do module swapping on retraced programs, which is still not possible. Differential Revision: [D67539304](https://our.internmc.facebook.com/intern/diff/D67539304/) Pull Request resolved: #143676 Approved by: https://github.com/zhxchen17, https://github.com/tugsbayasgalan ghstack dependencies: #143664
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
When we unflatten, the submodules we generate (
InterpreterModuleorInterpreterModuleDispatcher) are not related by type to the original submodulesN. This makesisinstance(mod, N)checks fail. Since we do not have the original types after export, the best we can do is expose atype_name()method that carries the original type name, which we do carry innn_module_stackentries.Differential Revision: D67526542
cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o