[Feat]: Add Multithreading support for kleidiai groupwise GEMM kernels #144074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhil-arm
requested review from
IvanYashchuk,
lezcano and
nikitaved
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144074
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 85a3252 with merge base 0431d47 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
module: cpu
Signed-off-by: Nikhil Gupta <nikhil.gupta2@arm.com> Change-Id: I2cb782e8a8414adbee6bfe317bee5bb040f4f982
nikhil-arm
force-pushed
the
groupwise_gemm_multithreading
branch
from
b8f0a14 to
1dfb724
Compare
nikhil-arm
changed the title
nikhil-arm
requested review from
digantdesai
and removed request for
IvanYashchuk and
lezcano
cpuhrsch
added
the
triaged
digantdesai
approved these changes
Jan 9, 2025
Signed-off-by: Nikhil Gupta <nikhil.gupta2@arm.com> Change-Id: I307c21fbe0fad0dd9793f39cef55167d553c091b
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 22, 2025
Mitigation for #145273 Reverting #134124 and #144074 Pull Request resolved: #145392 Approved by: https://github.com/ZainRizvi, https://github.com/malfet, https://github.com/atalman, https://github.com/digantdesai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KleidiAI Groupwise GEMM Kernel was not 2D Blocked. This change adds supports for 2D blocking of GEMM kernel to efficiently split workload & speedup GEMM kernel over multiple threads.
Performance improvements:
7B model Pre-fill speedup from 145 t/s to 175 t/s
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov @BoyuanFeng