[aoti] Deduplicate "V.aot_compilation" and "V.graph.aot_mode" flags. [1/n] #144709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144709
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit e3c9678 with merge base 898a90c ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D68122536 |
zhxchen17
force-pushed
the
export-D68122536
branch
from
e04b268 to
28a740c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68122536 |
zhxchen17
changed the title
zhxchen17
force-pushed
the
export-D68122536
branch
from
28a740c to
1b20d4a
Compare
zhxchen17
added a commit
to zhxchen17/pytorch
that referenced
this pull request
Jan 14, 2025
…[1/n] (pytorch#144709) Summary: According to angelayi, these two flags indicated different things when we have two-pass codegen but since now we basically keep the two flags all the same, we should merge two flags. This can prevent some bug (e.g. we change value of aot_mode which will not cover branches like if V.aot_compialtion is True) from happening when we're trying to add different code paths to tweak the value of aot_mode in the future. Test Plan: CI Differential Revision: D68122536
|
This pull request was exported from Phabricator. Differential Revision: D68122536 |
angelayi
approved these changes
Jan 14, 2025
zhxchen17
force-pushed
the
export-D68122536
branch
from
1b20d4a to
d5ec126
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68122536 |
zhxchen17
force-pushed
the
export-D68122536
branch
from
d5ec126 to
2eca13e
Compare
…[1/n] (pytorch#144709) Summary: According to angelayi, these two flags indicated different things when we have two-pass codegen but since now we basically keep the two flags all the same, we should merge two flags. This can prevent some bug (e.g. we change value of aot_mode which will not cover branches like if V.aot_compialtion is True) from happening when we're trying to add different code paths to tweak the value of aot_mode in the future. Test Plan: CI Reviewed By: angelayi Differential Revision: D68122536
zhxchen17
force-pushed
the
export-D68122536
branch
from
2eca13e to
e3c9678
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68122536 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68122536 |
desertfire
approved these changes
Jan 16, 2025
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
According to angelayi, these two flags indicated different things when we have two-pass codegen but since now we basically keep the two flags all the same, we should merge two flags.
This can prevent some bug (e.g. we change value of aot_mode which will not cover branches like if V.aot_compialtion is True) from happening when we're trying to add different code paths to tweak the value of aot_mode in the future.
Test Plan: CI
Differential Revision: D68122536
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov @BoyuanFeng