[Dynamo] Allow `format()` to handle int #144956

shink · 2025-01-16T09:44:18Z

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

pytorch-bot · 2025-01-16T09:44:22Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144956

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (7 Unrelated Failures)

As of commit fc62ca6 with merge base d95a6ba ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / linux-focal-cuda12.4-py3.10-gcc9 / test (default, 5, 5, linux.4xlarge.nvidia.gpu) (gh) (disabled by #131303 but the issue was closed recently and a rebase is needed to make it pass)
dynamo/test_exc.py::ExcTests::test_trigger_bisect_on_error
pull / linux-focal-cuda12.4-py3.10-gcc9-sm89 / test (default, 3, 5, linux.g6.4xlarge.experimental.nvidia.gpu) (gh) (disabled by #131303 but the issue was closed recently and a rebase is needed to make it pass)
dynamo/test_exc.py::ExcTests::test_trigger_bisect_on_error
pull / linux-focal-py3.13-clang10 / test (default, 3, 5, linux.4xlarge) (gh) (disabled by #131303 but the issue was closed recently and a rebase is needed to make it pass)
dynamo/test_exc.py::ExcTests::test_trigger_bisect_on_error
pull / linux-focal-py3.9-clang10 / test (default, 5, 5, linux.4xlarge) (gh) (disabled by #131303 but the issue was closed recently and a rebase is needed to make it pass)
dynamo/test_exc.py::ExcTests::test_trigger_bisect_on_error
pull / linux-jammy-py3.10-clang15-asan / test (default, 4, 6, linux.4xlarge) (gh) (disabled by #131303 but the issue was closed recently and a rebase is needed to make it pass)
dynamo/test_exc.py::ExcTests::test_trigger_bisect_on_error
pull / linux-jammy-py3.9-gcc11 / test (default, 5, 5, linux.2xlarge) (gh) (disabled by #131303 but the issue was closed recently and a rebase is needed to make it pass)
dynamo/test_exc.py::ExcTests::test_trigger_bisect_on_error
trunk / macos-py3-arm64 / test (default, 3, 3, macos-m1-stable) (gh) (disabled by #131303 but the issue was closed recently and a rebase is needed to make it pass)
dynamo/test_exc.py::ExcTests::test_trigger_bisect_on_error

This comment was automatically generated by Dr. CI and updates every 15 minutes.

shink · 2025-01-16T12:39:30Z

@pytorchbot label "topic: not user facing"

shink · 2025-01-16T12:50:13Z

@pytorchbot rebase -b main

pytorchmergebot · 2025-01-16T12:51:51Z

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

pytorchmergebot · 2025-01-16T12:51:56Z

Successfully rebased fix/dynamo/format onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout fix/dynamo/format && git pull --rebase)

shink · 2025-01-16T12:52:39Z

torch/_dynamo/variables/builtin.py

    def call_format(self, tx: "InstructionTranslator", _format_string, *args, **kwargs):
        format_string = _format_string.as_python_constant()
+        format_string = str(format_string)
        return variables.StringFormatVariable.create(format_string, args, kwargs)


Make sure format_string is a string, right?

jansel · 2025-01-23T01:57:34Z

@pytorchbot merge

pytorchmergebot · 2025-01-23T01:59:37Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-01-23T02:10:30Z

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

shink · 2025-01-23T02:42:41Z

@pytorchbot rebase -b main

pytorchmergebot · 2025-01-23T02:44:06Z

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

pytorchmergebot · 2025-01-23T02:44:08Z

Successfully rebased fix/dynamo/format onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout fix/dynamo/format && git pull --rebase)

jansel

Looks like the newly added test is failing for dynamic shapes.

shink · 2025-01-24T01:27:41Z

@jansel Thanks for your review! Seems format() does not support dynamic shapes in Dynamo. I just let dynamic=False, it's right? See this commit: fc62ca6

jansel · 2025-01-25T04:05:18Z

@pytorchbot merge

pytorchmergebot · 2025-01-25T04:06:54Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Fixes pytorch#144830 Pull Request resolved: pytorch#144956 Approved by: https://github.com/jansel

pytorch-bot bot added the module: dynamo label Jan 16, 2025

pytorchbot added the open source label Jan 16, 2025

pytorch-bot bot added the topic: not user facing topic category label Jan 16, 2025

pytorchmergebot force-pushed the fix/dynamo/format branch from 8e4bf36 to 50cec8b Compare January 16, 2025 12:51

shink commented Jan 16, 2025

View reviewed changes

mikaylagawarecki requested a review from jansel January 22, 2025 15:34

mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 22, 2025

jansel approved these changes Jan 23, 2025

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 23, 2025

pytorchmergebot added the merging label Jan 23, 2025

pytorchmergebot removed the merging label Jan 23, 2025

shink added 2 commits January 23, 2025 02:44

allow 'format()' to handle int

654ed6f

add ut

8957037

pytorchmergebot force-pushed the fix/dynamo/format branch from 50cec8b to 8957037 Compare January 23, 2025 02:44

pytorch-bot bot temporarily deployed to upload-benchmark-results January 23, 2025 03:15 Inactive

jansel requested changes Jan 23, 2025

View reviewed changes

let dynamic=False

fc62ca6

pytorch-bot bot temporarily deployed to upload-benchmark-results January 24, 2025 01:53 Inactive

shink requested a review from jansel January 25, 2025 03:07

jansel approved these changes Jan 25, 2025

View reviewed changes

pytorchmergebot added the merging label Jan 25, 2025

pytorchmergebot added the Merged label Jan 25, 2025

pytorchmergebot closed this in cc1ecea Jan 25, 2025

pytorchmergebot removed the merging label Jan 25, 2025

nWEIdia pushed a commit to nWEIdia/pytorch that referenced this pull request Jan 27, 2025

[Dynamo] Allow format() to handle int (pytorch#144956)

1408ae7

Fixes pytorch#144830 Pull Request resolved: pytorch#144956 Approved by: https://github.com/jansel

[Dynamo] Allow format() to handle int #144956

[Dynamo] Allow format() to handle int #144956

Uh oh!

Conversation

shink commented Jan 16, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144956

✅ You can merge normally! (7 Unrelated Failures)

Uh oh!

shink commented Jan 16, 2025

Uh oh!

shink commented Jan 16, 2025

Uh oh!

pytorchmergebot commented Jan 16, 2025

Uh oh!

pytorchmergebot commented Jan 16, 2025

Uh oh!

shink Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

jansel commented Jan 23, 2025

Uh oh!

pytorchmergebot commented Jan 23, 2025

Merge started

Uh oh!

pytorchmergebot commented Jan 23, 2025

Merge failed

Uh oh!

shink commented Jan 23, 2025

Uh oh!

pytorchmergebot commented Jan 23, 2025

Uh oh!

pytorchmergebot commented Jan 23, 2025

Uh oh!

jansel left a comment

Choose a reason for hiding this comment

Uh oh!

shink commented Jan 24, 2025

Uh oh!

jansel commented Jan 25, 2025

Uh oh!

pytorchmergebot commented Jan 25, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[Dynamo] Allow `format()` to handle int #144956

[Dynamo] Allow `format()` to handle int #144956

shink commented Jan 16, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Jan 16, 2025 •

edited

Loading