Validate matching input shapes in Int8Add operator #14520
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maratyszcza
force-pushed
the
export-D13250922
branch
from
365c850 to
aa8b040
Compare
Summary: Pull Request resolved: pytorch#14520 Default engine doesn't support broadcast semantics in Int8Add operator. This patch adds a check that shapes are equivalent. Reviewed By: bertmaher Differential Revision: D13250922 fbshipit-source-id: 886ae3951d21e6745e0f162e43a9ac9e837339a0
Maratyszcza
force-pushed
the
export-D13250922
branch
from
aa8b040 to
1f18e7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Default engine doesn't support broadcast semantics in Int8Add operator. This patch adds a check that shapes are equivalent.
Differential Revision: D13250922