Skip to content

Conversation

min-jean-cho
Copy link
Collaborator

@min-jean-cho min-jean-cho commented Jan 23, 2025

Part of intel/torch-xpu-ops#1141.

The TORCH_API macro is added to export the symbol NestedTensor_to_mask, which is needed by libtroch_xpu for NestedTensor_softmax_dropout_xpu.

Copy link

pytorch-bot bot commented Jan 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145467

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 043bbb2 with merge base 6f07847 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@min-jean-cho min-jean-cho added the topic: not user facing topic category label Jan 23, 2025
@min-jean-cho min-jean-cho requested a review from guangyey January 23, 2025 08:02
@min-jean-cho min-jean-cho changed the title [Intel GPU] Add TORCH_API macro to NestedTensor_to_mask for NestedTensorXPU compatibility [Intel GPU] Add TORCH_API macro to export symbol NestedTensor_to_mask for libtorch_xpu Jan 23, 2025
@ezyang
Copy link
Contributor

ezyang commented Jan 24, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 24, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorch-bot pytorch-bot bot had a problem deploying to upload-benchmark-results January 24, 2025 04:57 Error
@pytorch-bot pytorch-bot bot had a problem deploying to upload-benchmark-results January 24, 2025 04:57 Error
@pytorch-bot pytorch-bot bot had a problem deploying to upload-benchmark-results January 24, 2025 04:57 Error
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 3, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

@guangyey
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased minjean/nested_tensor_xpu onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout minjean/nested_tensor_xpu && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the minjean/nested_tensor_xpu branch from de33ae7 to 043bbb2 Compare January 24, 2025 07:24
@guangyey
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 24, 2025 07:54 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 24, 2025 07:54 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 24, 2025 07:54 Inactive
@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@ezyang
Copy link
Contributor

ezyang commented Jan 24, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

github-merge-queue bot pushed a commit to intel/torch-xpu-ops that referenced this pull request Jan 26, 2025
Part of #1141.

Depends on pytorch/pytorch#145467.

- `_nested_tensor_softmax_with_shape`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants